]> www.infradead.org Git - users/willy/linux.git/commitdiff
ALSA: lx6464es: Cleanup the print API usages
authorTakashi Iwai <tiwai@suse.de>
Wed, 7 Aug 2024 13:34:29 +0000 (15:34 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 8 Aug 2024 05:49:46 +0000 (07:49 +0200)
Use pr_debug() instead of open-coded printk().
Also drop a few snd_printdd() calls that can be better done via
ftrace.

Reviewed-by: Jaroslav Kysela <perex@perex.cz>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20240807133452.9424-40-tiwai@suse.de
sound/pci/lx6464es/lx_core.c
sound/pci/lx6464es/lx_core.h

index b5b0d43bb8dcdd23a91dac3c2f14f06a9f0fe3db..9d95ecb299aed87350452f6c4bd7dd58cfbbe150 100644 (file)
@@ -231,14 +231,14 @@ static void lx_message_dump(struct lx_rmh *rmh)
        u8 idx = rmh->cmd_idx;
        int i;
 
-       snd_printk(LXRMH "command %s\n", dsp_commands[idx].dcOpName);
+       pr_debug(LXRMH "command %s\n", dsp_commands[idx].dcOpName);
 
        for (i = 0; i != rmh->cmd_len; ++i)
-               snd_printk(LXRMH "\tcmd[%d] %08x\n", i, rmh->cmd[i]);
+               pr_debug(LXRMH "\tcmd[%d] %08x\n", i, rmh->cmd[i]);
 
        for (i = 0; i != rmh->stat_len; ++i)
-               snd_printk(LXRMH "\tstat[%d]: %08x\n", i, rmh->stat[i]);
-       snd_printk("\n");
+               pr_debug(LXRMH "\tstat[%d]: %08x\n", i, rmh->stat[i]);
+       pr_debug("\n");
 }
 #else
 static inline void lx_message_dump(struct lx_rmh *rmh)
index 296013c910b7bb7f647a446a3f84861ea3986458..c1113439f7c9dddd626c3aac8ff34c9a30edb06d 100644 (file)
@@ -129,21 +129,18 @@ int lx_stream_set_state(struct lx6464es *chip, u32 pipe,
 static inline int lx_stream_start(struct lx6464es *chip, u32 pipe,
                                  int is_capture)
 {
-       snd_printdd("->lx_stream_start\n");
        return lx_stream_set_state(chip, pipe, is_capture, SSTATE_RUN);
 }
 
 static inline int lx_stream_pause(struct lx6464es *chip, u32 pipe,
                                  int is_capture)
 {
-       snd_printdd("->lx_stream_pause\n");
        return lx_stream_set_state(chip, pipe, is_capture, SSTATE_PAUSE);
 }
 
 static inline int lx_stream_stop(struct lx6464es *chip, u32 pipe,
                                 int is_capture)
 {
-       snd_printdd("->lx_stream_stop\n");
        return lx_stream_set_state(chip, pipe, is_capture, SSTATE_STOP);
 }