]> www.infradead.org Git - users/hch/misc.git/commitdiff
ALSA: rme32: Fix serialization in snd_rme32_capture_adat_open()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 3 Sep 2025 05:52:24 +0000 (08:52 +0300)
committerTakashi Iwai <tiwai@suse.de>
Wed, 3 Sep 2025 07:21:58 +0000 (09:21 +0200)
We accidentally deleted the wrong line of code when we did the
conversion to guard() locks.  If the rme32->capture_substream has
already been set we should return -EBUSY.

Fixes: 8bb75ae244c5 ("ALSA: rme32: Use guard() for spin locks")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/aLfXmIQRFTXr5h8O@stanley.mountain
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/rme32.c

index 123dddcb69721110f93b32a217000ca8638fc321..ca9bbf55465091e12b7f73777a85b073c0428933 100644 (file)
@@ -936,7 +936,7 @@ snd_rme32_capture_adat_open(struct snd_pcm_substream *substream)
         
        scoped_guard(spinlock_irq, &rme32->lock) {
                if (rme32->capture_substream != NULL)
-                       spin_unlock_irq(&rme32->lock);
+                       return -EBUSY;
                rme32->capture_substream = substream;
        }