of: Remove of_dev_{get,put}()

of_dev_get() and of_dev_put are just wrappers for get_device()/put_device()
on a platform_device. There's also already platform_device_{get,put}()
wrappers for this purpose. Let's update the few users and remove
of_dev_{get,put}().

Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Jakub Kicinski <kuba@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>
Cc: Patrice Chotard <patrice.chotard@st.com>
Cc: Felipe Balbi <balbi@kernel.org>
Cc: Julia Lawall <Julia.Lawall@inria.fr>
Cc: Gilles Muller <Gilles.Muller@inria.fr>
Cc: Nicolas Palix <nicolas.palix@imag.fr>
Cc: Michal Marek <michal.lkml@markovi.net>
Cc: linuxppc-dev@lists.ozlabs.org
Cc: netdev@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-usb@vger.kernel.org
Cc: cocci@systeme.lip6.fr
Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Link: https://lore.kernel.org/r/20210211232745.1498137-2-robh@kernel.org

diff --git a/arch/powerpc/platforms/pseries/ibmebus.c b/arch/powerpc/platforms/pseries/ibmebus.c
index 8c6e509f696756e5a877af8a4e9161263bcc1671..a15ab33646b30ed90f4d0e06f8ae719ed55a4e59 100644 (file)
--- a/arch/powerpc/platforms/pseries/ibmebus.c
+++ b/arch/powerpc/platforms/pseries/ibmebus.c
@@ -355,12 +355,12 @@ static int ibmebus_bus_device_probe(struct device *dev)
        if (!drv->probe)
                return error;
 
-       of_dev_get(of_dev);
+       get_device(dev);
 
        if (of_driver_match_device(dev, dev->driver))
                error = drv->probe(of_dev);
        if (error)
-               of_dev_put(of_dev);
+               put_device(dev);
 
        return error;
 }

diff --git a/drivers/net/ethernet/ibm/emac/core.c b/drivers/net/ethernet/ibm/emac/core.c
index c00b9097eeea413755ead5d1f6e0949be72abe21..471be6ec7e8a45b1daa2eb6f3523e4c79ac178f5 100644 (file)
--- a/drivers/net/ethernet/ibm/emac/core.c
+++ b/drivers/net/ethernet/ibm/emac/core.c
@@ -38,6 +38,7 @@
 #include <linux/of_irq.h>
 #include <linux/of_net.h>
 #include <linux/of_mdio.h>
+#include <linux/platform_device.h>
 #include <linux/slab.h>
 
 #include <asm/processor.h>
@@ -2390,11 +2391,11 @@ static int emac_check_deps(struct emac_instance *dev,
 
 static void emac_put_deps(struct emac_instance *dev)
 {
-       of_dev_put(dev->mal_dev);
-       of_dev_put(dev->zmii_dev);
-       of_dev_put(dev->rgmii_dev);
-       of_dev_put(dev->mdio_dev);
-       of_dev_put(dev->tah_dev);
+       platform_device_put(dev->mal_dev);
+       platform_device_put(dev->zmii_dev);
+       platform_device_put(dev->rgmii_dev);
+       platform_device_put(dev->mdio_dev);
+       platform_device_put(dev->tah_dev);
 }
 
 static int emac_of_bus_notify(struct notifier_block *nb, unsigned long action,
@@ -2435,7 +2436,7 @@ static int emac_wait_deps(struct emac_instance *dev)
        for (i = 0; i < EMAC_DEP_COUNT; i++) {
                of_node_put(deps[i].node);
                if (err)
-                       of_dev_put(deps[i].ofdev);
+                       platform_device_put(deps[i].ofdev);
        }
        if (err == 0) {
                dev->mal_dev = deps[EMAC_DEP_MAL_IDX].ofdev;
@@ -2444,7 +2445,7 @@ static int emac_wait_deps(struct emac_instance *dev)
                dev->tah_dev = deps[EMAC_DEP_TAH_IDX].ofdev;
                dev->mdio_dev = deps[EMAC_DEP_MDIO_IDX].ofdev;
        }
-       of_dev_put(deps[EMAC_DEP_PREV_IDX].ofdev);
+       platform_device_put(deps[EMAC_DEP_PREV_IDX].ofdev);
        return err;
 }
 

diff --git a/drivers/of/device.c b/drivers/of/device.c
index aedfaaafd3e7edb73a4468cba26cf2c177ea1164..9a748855b39d89e08ea93e8c2b3d292f122c7c03 100644 (file)
--- a/drivers/of/device.c
+++ b/drivers/of/device.c
@@ -33,27 +33,6 @@ const struct of_device_id *of_match_device(const struct of_device_id *matches,
 }
 EXPORT_SYMBOL(of_match_device);
 
-struct platform_device *of_dev_get(struct platform_device *dev)
-{
-       struct device *tmp;
-
-       if (!dev)
-               return NULL;
-       tmp = get_device(&dev->dev);
-       if (tmp)
-               return to_platform_device(tmp);
-       else
-               return NULL;
-}
-EXPORT_SYMBOL(of_dev_get);
-
-void of_dev_put(struct platform_device *dev)
-{
-       if (dev)
-               put_device(&dev->dev);
-}
-EXPORT_SYMBOL(of_dev_put);
-
 int of_device_add(struct platform_device *ofdev)
 {
        BUG_ON(ofdev->dev.of_node == NULL);

diff --git a/drivers/of/platform.c b/drivers/of/platform.c
index 79bd5f5a1bf171758cd2a802a16a63c12c86c074..020bf860c72c875ae967cdebbbe49d09360dd168 100644 (file)
--- a/drivers/of/platform.c
+++ b/drivers/of/platform.c
@@ -687,7 +687,7 @@ static int of_platform_notify(struct notifier_block *nb,
                pdev_parent = of_find_device_by_node(rd->dn->parent);
                pdev = of_platform_device_create(rd->dn, NULL,
                                pdev_parent ? &pdev_parent->dev : NULL);
-               of_dev_put(pdev_parent);
+               platform_device_put(pdev_parent);
 
                if (pdev == NULL) {
                        pr_err("%s: failed to create for '%pOF'\n",
@@ -712,7 +712,7 @@ static int of_platform_notify(struct notifier_block *nb,
                of_platform_device_destroy(&pdev->dev, &children_left);
 
                /* and put the reference of the find */
-               of_dev_put(pdev);
+               platform_device_put(pdev);
                break;
        }
 

diff --git a/drivers/of/unittest.c b/drivers/of/unittest.c
index eb51bc147440172ceb00ba4239e72f0c1bc358a8..eb100627c186adab7138549fc76b81f6e8e5908e 100644 (file)
--- a/drivers/of/unittest.c
+++ b/drivers/of/unittest.c
@@ -1286,7 +1286,7 @@ static void __init of_unittest_platform_populate(void)
                        unittest(pdev,
                                 "Could not create device for node '%pOFn'\n",
                                 grandchild);
-                       of_dev_put(pdev);
+                       platform_device_put(pdev);
                }
        }
 

diff --git a/drivers/usb/dwc3/dwc3-st.c b/drivers/usb/dwc3/dwc3-st.c
index e733be84054597fb15063ffb2d3ca7452e196d02..b06b7092b1a2d3fbbaac0b9ef57310df5dea9fd6 100644 (file)
--- a/drivers/usb/dwc3/dwc3-st.c
+++ b/drivers/usb/dwc3/dwc3-st.c
@@ -274,7 +274,7 @@ static int st_dwc3_probe(struct platform_device *pdev)
 
        dwc3_data->dr_mode = usb_get_dr_mode(&child_pdev->dev);
        of_node_put(child);
-       of_dev_put(child_pdev);
+       platform_device_put(child_pdev);
 
        /*
         * Configure the USB port as device or host according to the static

diff --git a/include/linux/of_device.h b/include/linux/of_device.h
index 937f32f6aecb202c55f9011790e434928f970d77..d7a407dfeecb4ea706817f95b302ed84d4daae62 100644 (file)
--- a/include/linux/of_device.h
+++ b/include/linux/of_device.h
@@ -26,9 +26,6 @@ static inline int of_driver_match_device(struct device *dev,
        return of_match_device(drv->of_match_table, dev) != NULL;
 }
 
-extern struct platform_device *of_dev_get(struct platform_device *dev);
-extern void of_dev_put(struct platform_device *dev);
-
 extern int of_device_add(struct platform_device *pdev);
 extern int of_device_register(struct platform_device *ofdev);
 extern void of_device_unregister(struct platform_device *ofdev);

diff --git a/scripts/coccinelle/free/put_device.cocci b/scripts/coccinelle/free/put_device.cocci
index 120921366e842d212df005329e17a2fcf270c055..f09f1e79bfa6805495b5c16094e685d4b86e37ff 100644 (file)
--- a/scripts/coccinelle/free/put_device.cocci
+++ b/scripts/coccinelle/free/put_device.cocci
@@ -21,7 +21,6 @@ id = of_find_device_by_node@p1(x)
 if (id == NULL || ...) { ... return ...; }
 ... when != put_device(&id->dev)
     when != platform_device_put(id)
-    when != of_dev_put(id)
     when != if (id) { ... put_device(&id->dev) ... }
     when != e1 = (T)id
     when != e1 = (T)(&id->dev)