staging: rtl8188eu: remove all DBG_88E calls from os_dep/os_intfs.c

Remove all DBG_88E calls from os_dep/os_intfs.c as this macro is
unnecessary, and many of these calls are dubious in terms of necessity.
Removing all calls will ultimately allow the removal of the macro
itself. Also remove variable declarations for variables which now go
unused as a result of this change with os_dep/os_intfs.c

Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210615001507.1171-14-phil@philpotter.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8188eu/os_dep/os_intfs.c b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
index 870148020e615b1788d261b1150032e59a658bcf..70e9161a429eef38e3b5cc32d8c01b0e866dac0a 100644 (file)
--- a/drivers/staging/rtl8188eu/os_dep/os_intfs.c
+++ b/drivers/staging/rtl8188eu/os_dep/os_intfs.c
@@ -310,7 +310,6 @@ struct net_device *rtw_init_netdev(void)
        pnetdev->dev.type = &wlan_type;
        padapter = netdev_priv(pnetdev);
        padapter->pnetdev = pnetdev;
-       DBG_88E("register rtw_netdev_ops to netdev_ops\n");
        pnetdev->netdev_ops = &rtw_netdev_ops;
        pnetdev->watchdog_timeo = HZ * 3; /* 3 second timeout */
        pnetdev->wireless_handlers = (struct iw_handler_def *)&rtw_handlers_def;
@@ -439,19 +438,16 @@ u8 rtw_init_drv_sw(struct adapter *padapter)
        }
 
        if (_rtw_init_xmit_priv(&padapter->xmitpriv, padapter) == _FAIL) {
-               DBG_88E("Can't _rtw_init_xmit_priv\n");
                ret8 = _FAIL;
                goto exit;
        }
 
        if (_rtw_init_recv_priv(&padapter->recvpriv, padapter) == _FAIL) {
-               DBG_88E("Can't _rtw_init_recv_priv\n");
                ret8 = _FAIL;
                goto exit;
        }
 
        if (_rtw_init_sta_priv(&padapter->stapriv) == _FAIL) {
-               DBG_88E("Can't _rtw_init_sta_priv\n");
                ret8 = _FAIL;
                goto exit;
        }
@@ -530,7 +526,6 @@ static int _netdev_open(struct net_device *pnetdev)
        struct pwrctrl_priv *pwrctrlpriv = &padapter->pwrctrlpriv;
 
        RT_TRACE(_module_os_intfs_c_, _drv_info_, ("+88eu_drv - dev_open\n"));
-       DBG_88E("+88eu_drv - drv_open, bup =%d\n", padapter->bup);
 
        if (pwrctrlpriv->ps_flag) {
                padapter->net_closed = false;
@@ -580,7 +575,6 @@ static int _netdev_open(struct net_device *pnetdev)
 
 netdev_open_normal_process:
        RT_TRACE(_module_os_intfs_c_, _drv_info_, ("-88eu_drv - dev_open\n"));
-       DBG_88E("-88eu_drv - drv_open, bup =%d\n", padapter->bup);
        return 0;
 
 netdev_open_error:
@@ -588,7 +582,6 @@ netdev_open_error:
        netif_carrier_off(pnetdev);
        netif_tx_stop_all_queues(pnetdev);
        RT_TRACE(_module_os_intfs_c_, _drv_err_, ("-88eu_drv - dev_open, fail!\n"));
-       DBG_88E("-88eu_drv - drv_open fail, bup =%d\n", padapter->bup);
        return -1;
 }
 
@@ -609,7 +602,6 @@ int  ips_netdrv_open(struct adapter *padapter)
        int status = _SUCCESS;
 
        padapter->net_closed = false;
-       DBG_88E("===> %s.........\n", __func__);
 
        padapter->bDriverStopped = false;
        padapter->bSurpriseRemoved = false;
@@ -629,47 +621,33 @@ int  ips_netdrv_open(struct adapter *padapter)
        return _SUCCESS;
 
 netdev_open_error:
-       DBG_88E("-%s - drv_open failure, bup =%d\n", __func__, padapter->bup);
-
        return _FAIL;
 }
 
 int rtw_ips_pwr_up(struct adapter *padapter)
 {
        int result;
-       unsigned long start_time = jiffies;
 
-       DBG_88E("===>  %s..............\n", __func__);
        rtw_reset_drv_sw(padapter);
 
        result = ips_netdrv_open(padapter);
 
        led_control_8188eu(padapter, LED_CTL_NO_LINK);
 
-       DBG_88E("<===  %s.............. in %dms\n", __func__,
-               jiffies_to_msecs(jiffies - start_time));
        return result;
 }
 
 void rtw_ips_pwr_down(struct adapter *padapter)
 {
-       unsigned long start_time = jiffies;
-
-       DBG_88E("===> %s...................\n", __func__);
-
        padapter->net_closed = true;
 
        led_control_8188eu(padapter, LED_CTL_POWER_OFF);
 
        rtw_ips_dev_unload(padapter);
-       DBG_88E("<=== %s..................... in %dms\n", __func__,
-               jiffies_to_msecs(jiffies - start_time));
 }
 
 void rtw_ips_dev_unload(struct adapter *padapter)
 {
-       DBG_88E("====> %s...\n", __func__);
-
        rtw_hal_set_hwreg(padapter, HW_VAR_FIFO_CLEARN_UP, NULL);
 
        usb_intf_stop(padapter);
@@ -692,9 +670,6 @@ static int netdev_close(struct net_device *pnetdev)
        padapter->net_closed = true;
 
        if (padapter->pwrctrlpriv.rf_pwrstate == rf_on) {
-               DBG_88E("(2)88eu_drv - drv_close, bup =%d, hw_init_completed =%d\n",
-                       padapter->bup, padapter->hw_init_completed);
-
                /* s1. */
                if (pnetdev) {
                        if (!rtw_netif_queue_stopped(pnetdev))
@@ -715,6 +690,5 @@ static int netdev_close(struct net_device *pnetdev)
        }
 
        RT_TRACE(_module_os_intfs_c_, _drv_info_, ("-88eu_drv - drv_close\n"));
-       DBG_88E("-88eu_drv - drv_close, bup =%d\n", padapter->bup);
        return 0;
 }