]> www.infradead.org Git - linux.git/commitdiff
MIPS: KVM: Fix a build warning about variable set but not used
authorHuacai Chen <chenhuacai@loongson.cn>
Tue, 10 Oct 2023 08:54:34 +0000 (16:54 +0800)
committerThomas Bogendoerfer <tsbogend@alpha.franken.de>
Thu, 19 Oct 2023 08:25:31 +0000 (10:25 +0200)
After commit 411740f5422a ("KVM: MIPS/MMU: Implement KVM_CAP_SYNC_MMU")
old_pte is no longer used in kvm_mips_map_page(). So remove it to fix a
build warning about variable set but not used:

   arch/mips/kvm/mmu.c: In function 'kvm_mips_map_page':
>> arch/mips/kvm/mmu.c:701:29: warning: variable 'old_pte' set but not used [-Wunused-but-set-variable]
     701 |         pte_t *ptep, entry, old_pte;
         |                             ^~~~~~~

Cc: stable@vger.kernel.org
Fixes: 411740f5422a960 ("KVM: MIPS/MMU: Implement KVM_CAP_SYNC_MMU")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202310070530.aARZCSfh-lkp@intel.com/
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
arch/mips/kvm/mmu.c

index 7b2ac1319d70acafd68cfe6b30680abc7bd04234..467ee6b95ae1c6c9e795f3446886797aa51b7372 100644 (file)
@@ -592,7 +592,7 @@ static int kvm_mips_map_page(struct kvm_vcpu *vcpu, unsigned long gpa,
        gfn_t gfn = gpa >> PAGE_SHIFT;
        int srcu_idx, err;
        kvm_pfn_t pfn;
-       pte_t *ptep, entry, old_pte;
+       pte_t *ptep, entry;
        bool writeable;
        unsigned long prot_bits;
        unsigned long mmu_seq;
@@ -664,7 +664,6 @@ retry:
        entry = pfn_pte(pfn, __pgprot(prot_bits));
 
        /* Write the PTE */
-       old_pte = *ptep;
        set_pte(ptep, entry);
 
        err = 0;