]> www.infradead.org Git - users/hch/misc.git/commitdiff
staging: gpib: tidy-up comments
authorLuke Yang <lukeyang.dev@gmail.com>
Thu, 14 Aug 2025 19:01:36 +0000 (15:01 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 19 Aug 2025 10:58:19 +0000 (12:58 +0200)
Improve comment readability:

- "//comment" -> "// comment"
- Align comments vertically in columns
- Enforce consistency between "// comments" and "/* comments */"

Signed-off-by: Luke Yang <lukeyang.dev@gmail.com>
Link: https://lore.kernel.org/r/aJ4ykOs_MmjnQdPa@luyang-thinkpadp1gen7.toromso.csb
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
27 files changed:
drivers/staging/gpib/agilent_82357a/agilent_82357a.c
drivers/staging/gpib/agilent_82357a/agilent_82357a.h
drivers/staging/gpib/cb7210/cb7210.h
drivers/staging/gpib/cec/cec_gpib.c
drivers/staging/gpib/common/gpib_os.c
drivers/staging/gpib/common/iblib.c
drivers/staging/gpib/eastwood/fluke_gpib.c
drivers/staging/gpib/fmh_gpib/fmh_gpib.c
drivers/staging/gpib/gpio/gpib_bitbang.c
drivers/staging/gpib/hp_82341/hp_82341.c
drivers/staging/gpib/hp_82341/hp_82341.h
drivers/staging/gpib/include/amccs5933.h
drivers/staging/gpib/include/gpib_types.h
drivers/staging/gpib/include/nec7210.h
drivers/staging/gpib/include/nec7210_registers.h
drivers/staging/gpib/include/plx9050.h
drivers/staging/gpib/include/tms9914.h
drivers/staging/gpib/include/tnt4882_registers.h
drivers/staging/gpib/ines/ines.h
drivers/staging/gpib/ines/ines_gpib.c
drivers/staging/gpib/nec7210/nec7210.c
drivers/staging/gpib/ni_usb/ni_usb_gpib.c
drivers/staging/gpib/ni_usb/ni_usb_gpib.h
drivers/staging/gpib/pc2/pc2_gpib.c
drivers/staging/gpib/tms9914/tms9914.c
drivers/staging/gpib/tnt4882/mite.h
drivers/staging/gpib/tnt4882/tnt4882_gpib.c

index b923dc606d1d36cb5c9fa01e105b00ba65125a49..77c8e549b2080047eda0db6fadf2c08ba828c1fd 100644 (file)
@@ -449,8 +449,8 @@ static int agilent_82357a_read(struct gpib_board *board, u8 *buffer, size_t leng
        if (!out_data)
                return -ENOMEM;
        out_data[i++] = DATA_PIPE_CMD_READ;
-       out_data[i++] = 0;      //primary address when ARF_NO_ADDR is not set
-       out_data[i++] = 0;      //secondary address when ARF_NO_ADDR is not set
+       out_data[i++] = 0;      // primary address when ARF_NO_ADDR is not set
+       out_data[i++] = 0;      // secondary address when ARF_NO_ADDR is not set
        out_data[i] = ARF_NO_ADDRESS | ARF_END_ON_EOI;
        if (a_priv->eos_mode & REOS)
                out_data[i] |= ARF_END_ON_EOS_CHAR;
@@ -532,7 +532,7 @@ static int agilent_82357a_read(struct gpib_board *board, u8 *buffer, size_t leng
         */
        agilent_82357a_take_control_internal(board, 0);
 
-       //FIXME check trailing flags for error
+       // FIXME check trailing flags for error
        return retval;
 }
 
@@ -966,7 +966,7 @@ static int agilent_82357a_parallel_poll(struct gpib_board *board, u8 *result)
                dev_err(&usb_dev->dev, "write_registers() returned error\n");
                return retval;
        }
-       udelay(2);      //silly, since usb write will take way longer
+       udelay(2);      // silly, since usb write will take way longer
        read.address = CPTR;
        retval = agilent_82357a_read_registers(a_priv, &read, 1, 1);
        if (retval) {
@@ -989,31 +989,31 @@ static int agilent_82357a_parallel_poll(struct gpib_board *board, u8 *result)
 
 static void agilent_82357a_parallel_poll_configure(struct gpib_board *board, u8 config)
 {
-       //board can only be system controller
+       // board can only be system controller
        return;// 0;
 }
 
 static void agilent_82357a_parallel_poll_response(struct gpib_board *board, int ist)
 {
-       //board can only be system controller
+       // board can only be system controller
        return;// 0;
 }
 
 static void agilent_82357a_serial_poll_response(struct gpib_board *board, u8 status)
 {
-       //board can only be system controller
+       // board can only be system controller
        return;// 0;
 }
 
 static u8 agilent_82357a_serial_poll_status(struct gpib_board *board)
 {
-       //board can only be system controller
+       // board can only be system controller
        return 0;
 }
 
 static void agilent_82357a_return_to_local(struct gpib_board *board)
 {
-       //board can only be system controller
+       // board can only be system controller
        return;// 0;
 }
 
index 23aa4799eb8628fe11e4d76381a4d85eb4dffb3a..33ac558e55528ea796b85f4624a241b1744f0c83 100644 (file)
@@ -20,7 +20,7 @@ enum usb_vendor_ids {
 enum usb_device_ids {
        USB_DEVICE_ID_AGILENT_82357A = 0x0107,
        USB_DEVICE_ID_AGILENT_82357A_PREINIT = 0x0007,  // device id before firmware is loaded
-       USB_DEVICE_ID_AGILENT_82357B = 0x0718,  // device id before firmware is loaded
+       USB_DEVICE_ID_AGILENT_82357B = 0x0718,          // device id before firmware is loaded
        USB_DEVICE_ID_AGILENT_82357B_PREINIT = 0x0518,  // device id before firmware is loaded
 };
 
@@ -129,10 +129,10 @@ struct agilent_82357a_priv {
        struct urb *bulk_urb;
        struct urb *interrupt_urb;
        u8 *interrupt_buffer;
-       struct mutex bulk_transfer_lock; // bulk transfer lock
-       struct mutex bulk_alloc_lock;    // bulk transfer allocation lock
-       struct mutex interrupt_alloc_lock; // interrupt allocation lock
-       struct mutex control_alloc_lock;   // control message allocation lock
+       struct mutex bulk_transfer_lock;        // bulk transfer lock
+       struct mutex bulk_alloc_lock;           // bulk transfer allocation lock
+       struct mutex interrupt_alloc_lock;      // interrupt allocation lock
+       struct mutex control_alloc_lock;        // control message allocation lock
        struct timer_list bulk_timer;
        struct agilent_82357a_urb_ctx context;
        unsigned int bulk_out_endpoint;
index 13f127563ab3a7e1ae1ba0068e4bf4badf19ba9b..ddc841ff87aee740bde68e66e25b4b2dcfde4eff 100644 (file)
@@ -56,10 +56,10 @@ enum cb7210_page_in {
 };
 
 enum hs_regs {
-       //write registers
+       // write registers
        HS_MODE = 0x8,  /* HS_MODE register */
        HS_INT_LEVEL = 0x9,     /* HS_INT_LEVEL register */
-       //read registers
+       // read registers
        HS_STATUS = 0x8,        /* HS_STATUS register */
 };
 
index 0c9d10ee7cd26e0ab45cea4fc149739faeb39b60..dbf9b95baabc937f61d3960ea29948715f47a396 100644 (file)
@@ -206,7 +206,7 @@ static struct gpib_interface cec_pci_interface = {
        .parallel_poll_configure = cec_parallel_poll_configure,
        .parallel_poll_response = cec_parallel_poll_response,
        .local_parallel_poll_mode = NULL, // XXX
-       .line_status = NULL,    //XXX
+       .line_status = NULL,    // XXX
        .update_status = cec_update_status,
        .primary_address = cec_primary_address,
        .secondary_address = cec_secondary_address,
index 2a0465ce16c4a9aa95c670cc21e6b93ab068e296..9dbbac8b84360e9d8af3e2cece1a8697f9480d34 100644 (file)
@@ -326,7 +326,7 @@ static int setup_serial_poll(struct gpib_board *board, unsigned int usec_timeout
        cmd_string[i++] = MLA(board->pad);      /* controller's listen address */
        if (board->sad >= 0)
                cmd_string[i++] = MSA(board->sad);
-       cmd_string[i++] = SPE;  //serial poll enable
+       cmd_string[i++] = SPE;  // serial poll enable
 
        ret = board->interface->command(board, cmd_string, i, &bytes_written);
        if (ret < 0 || bytes_written < i) {
index 549280d9a6e965d22e3346fc3079cfcde7fe1fcb..7cbb6a467177da2205a782aedca6091f93ff97cc 100644 (file)
@@ -608,7 +608,7 @@ static int wait_satisfied(struct wait_info *winfo, struct gpib_status_queue *sta
                *status = temp_status;
                return 1;
        }
-//XXX does wait for END work?
+// XXX does wait for END work?
        return 0;
 }
 
index 491356433249ec2c715f251870d8d7f2a1196bbc..3ae848e3f7386b6e502caa2e911688d54df2cbcd 100644 (file)
@@ -507,7 +507,7 @@ static int fluke_accel_write(struct gpib_board *board, u8 *buffer, size_t length
        }
        if (retval < 0)
                return retval;
-       //handle sending of last byte with eoi
+       // handle sending of last byte with eoi
        if (send_eoi) {
                size_t num_bytes;
 
index 4138f3d2bae7f44bd6bc83ae89205c0457011980..164dcfc3c9efff7f99bff0eb941714914a3fdd18 100644 (file)
@@ -523,7 +523,7 @@ static int fmh_gpib_accel_write(struct gpib_board *board, u8 *buffer,
        }
        if (retval < 0)
                return retval;
-       //handle sending of last byte with eoi
+       // handle sending of last byte with eoi
        if (send_eoi) {
                size_t num_bytes;
 
index 17884810fd69330915539391957c98e4a29d881b..22a55f3f794d4c7d5f923a50799054ced95c39bc 100644 (file)
@@ -277,8 +277,8 @@ struct bb_priv {
        int ndac_mode;       /* nrfd interrupt mode 0/1 -> edge/levels */
        int dav_tx;          /* keep trace of DAV status while sending */
        int dav_rx;          /* keep trace of DAV status while receiving */
-       u8 eos;      // eos character
-       short eos_flags;     // eos mode
+       u8 eos;              /* eos character */
+       short eos_flags;     /* eos mode */
        short eos_check;     /* eos check required in current operation ... */
        short eos_check_8;   /* ... with byte comparison */
        short eos_mask_7;    /* ... with 7 bit masked character */
@@ -290,14 +290,14 @@ struct bb_priv {
        u8 *rbuf;
        u8 *wbuf;
        int end_flag;
-       int r_busy;        /* 0==idle   1==busy  */
+       int r_busy;           /* 0==idle   1==busy */
        int w_busy;
        int write_done;
-       int cmd;           /* 1 = cmd write in  progress */
+       int cmd;              /* 1 = cmd write in progress */
        size_t w_cnt;
        size_t length;
        u8 *w_buf;
-       spinlock_t rw_lock; // protect mods to rw_lock
+       spinlock_t rw_lock;   /* protect mods to rw_lock */
        int phase;
        int ndac_idle;
        int ndac_seq;
@@ -1462,8 +1462,8 @@ static inline void SET_DIR_READ(struct bb_priv *priv)
                gpiod_set_value(TE, 0);  /* set NDAC and NRFD to transmit and DAV to receive */
        }
 
-       gpiod_direction_output(NRFD, 0);  // hold off the talker
-       gpiod_direction_output(NDAC, 0);  // data not accepted
+       gpiod_direction_output(NRFD, 0); /* hold off the talker */
+       gpiod_direction_output(NDAC, 0); /* data not accepted */
 
        priv->direction = DIR_READ;
 }
index e5c1997ce7d9cdfca71c27d6012ac71e44b83e5b..1a2ad0560e1416190115a968ad8a35612f98a2d1 100644 (file)
@@ -38,7 +38,7 @@ static int hp_82341_accel_read(struct gpib_board *board, u8 *buffer, size_t leng
        unsigned short event_status;
        int i;
        int num_fifo_bytes;
-       //hardware doesn't support checking for end-of-string character when using fifo
+       // hardware doesn't support checking for end-of-string character when using fifo
        if (tms_priv->eos_flags & REOS)
                return tms9914_read(board, tms_priv, buffer, length, end, bytes_read);
 
@@ -49,7 +49,7 @@ static int hp_82341_accel_read(struct gpib_board *board, u8 *buffer, size_t leng
        *bytes_read = 0;
        if (length == 0)
                return 0;
-       //disable fifo for the moment
+       // disable fifo for the moment
        outb(DIRECTION_GPIB_TO_HOST_BIT, hp_priv->iobase[3] + BUFFER_CONTROL_REG);
        /*
         * Handle corner case of board not in holdoff and one byte has slipped in already.
@@ -154,7 +154,7 @@ static int restart_write_fifo(struct gpib_board *board, struct hp_82341_priv *hp
        while (1) {
                int status;
 
-               //restart doesn't work if data holdoff is in effect
+               // restart doesn't work if data holdoff is in effect
                status = tms9914_line_status(board, tms_priv);
                if ((status & BUS_NRFD) == 0) {
                        outb(RESTART_STREAM_BIT, hp_priv->iobase[0] + STREAM_STATUS_REG);
@@ -764,7 +764,7 @@ static int hp_82341_attach(struct gpib_board *board, const struct gpib_board_con
             ENABLE_TI_INTERRUPT_EVENT_BIT, hp_priv->iobase[0] +  EVENT_ENABLE_REG);
        outb(ENABLE_BUFFER_END_INTERRUPT_BIT | ENABLE_TERMINAL_COUNT_INTERRUPT_BIT |
             ENABLE_TI_INTERRUPT_BIT, hp_priv->iobase[0] + INTERRUPT_ENABLE_REG);
-       //write clear event register
+       // write clear event register
        outb((TI_INTERRUPT_EVENT_BIT | POINTERS_EQUAL_EVENT_BIT |
              BUFFER_END_EVENT_BIT | TERMINAL_COUNT_EVENT_BIT),
             hp_priv->iobase[0] + EVENT_STATUS_REG);
@@ -867,7 +867,7 @@ static irqreturn_t hp_82341_interrupt(int irq, void *arg)
        event_status = inb(hp_priv->iobase[0] + EVENT_STATUS_REG);
        if (event_status & INTERRUPT_PENDING_EVENT_BIT)
                retval = IRQ_HANDLED;
-       //write-clear status bits
+       // write-clear status bits
        if (event_status & (TI_INTERRUPT_EVENT_BIT | POINTERS_EQUAL_EVENT_BIT |
                            BUFFER_END_EVENT_BIT | TERMINAL_COUNT_EVENT_BIT)) {
                outb(event_status & (TI_INTERRUPT_EVENT_BIT | POINTERS_EQUAL_EVENT_BIT |
@@ -901,7 +901,7 @@ static void set_transfer_counter(struct hp_82341_priv *hp_priv, int count)
 
        outb(complement & 0xff, hp_priv->iobase[1] + TRANSFER_COUNT_LOW_REG);
        outb((complement >> 8) & 0xff, hp_priv->iobase[1] + TRANSFER_COUNT_MID_REG);
-       //I don't think the hi count reg is even used, but oh well
+       // I don't think the hi count reg is even used, but oh well
        outb((complement >> 16) & 0xf, hp_priv->iobase[1] + TRANSFER_COUNT_HIGH_REG);
 }
 
index 370a3d4576ebbd826b712b6e9a91fa0139f1b2b1..859ef2899acbcab4fc543fc44ac878af8cdd699e 100644 (file)
@@ -65,7 +65,7 @@ enum config_control_status_bits {
        IRQ_SELECT_MASK = 0x7,
        DMA_CONFIG_MASK = 0x18,
        ENABLE_DMA_CONFIG_BIT = 0x20,
-       XILINX_READY_BIT = 0x40,        //read only
+       XILINX_READY_BIT = 0x40,        // read only
        DONE_PGL_BIT = 0x80
 };
 
@@ -94,7 +94,7 @@ static inline unsigned int IRQ_SELECT_BITS(int irq)
 };
 
 enum mode_control_status_bits {
-       SLOT8_BIT = 0x1,        // read only
+       SLOT8_BIT = 0x1,                // read only
        ACTIVE_CONTROLLER_BIT = 0x2,    // read only
        ENABLE_DMA_BIT = 0x4,
        SYSTEM_CONTROLLER_BIT = 0x8,
@@ -106,12 +106,12 @@ enum mode_control_status_bits {
 enum monitor_bits {
        MONITOR_INTERRUPT_PENDING_BIT = 0x1,    // read only
        MONITOR_CLEAR_HOLDOFF_BIT = 0x2,        // write only
-       MONITOR_PPOLL_BIT = 0x4,        // write clear
-       MONITOR_SRQ_BIT = 0x8,  // write clear
-       MONITOR_IFC_BIT = 0x10, // write clear
-       MONITOR_REN_BIT = 0x20, // write clear
-       MONITOR_END_BIT = 0x40, // write clear
-       MONITOR_DAV_BIT = 0x80  // write clear
+       MONITOR_PPOLL_BIT = 0x4,                // write clear
+       MONITOR_SRQ_BIT = 0x8,                  // write clear
+       MONITOR_IFC_BIT = 0x10,                 // write clear
+       MONITOR_REN_BIT = 0x20,                 // write clear
+       MONITOR_END_BIT = 0x40,                 // write clear
+       MONITOR_DAV_BIT = 0x80                  // write clear
 };
 
 enum interrupt_enable_bits {
@@ -123,36 +123,36 @@ enum interrupt_enable_bits {
 };
 
 enum event_status_bits {
-       TI_INTERRUPT_EVENT_BIT = 0x1,   //write clear
+       TI_INTERRUPT_EVENT_BIT = 0x1,           // write clear
        INTERRUPT_PENDING_EVENT_BIT = 0x2,      // read only
-       POINTERS_EQUAL_EVENT_BIT = 0x4, //write clear
-       BUFFER_END_EVENT_BIT = 0x10,    //write clear
+       POINTERS_EQUAL_EVENT_BIT = 0x4,         // write clear
+       BUFFER_END_EVENT_BIT = 0x10,            // write clear
        TERMINAL_COUNT_EVENT_BIT = 0x20,        // write clear
        DMA_TERMINAL_COUNT_EVENT_BIT = 0x80,    // write clear
 };
 
 enum event_enable_bits {
-       ENABLE_TI_INTERRUPT_EVENT_BIT = 0x1,    //write clear
-       ENABLE_POINTERS_EQUAL_EVENT_BIT = 0x4,  //write clear
-       ENABLE_BUFFER_END_EVENT_BIT = 0x10,     //write clear
-       ENABLE_TERMINAL_COUNT_EVENT_BIT = 0x20, // write clear
+       ENABLE_TI_INTERRUPT_EVENT_BIT = 0x1,            // write clear
+       ENABLE_POINTERS_EQUAL_EVENT_BIT = 0x4,          // write clear
+       ENABLE_BUFFER_END_EVENT_BIT = 0x10,             // write clear
+       ENABLE_TERMINAL_COUNT_EVENT_BIT = 0x20,         // write clear
        ENABLE_DMA_TERMINAL_COUNT_EVENT_BIT = 0x80,     // write clear
 };
 
 enum stream_status_bits {
-       HALTED_STATUS_BIT = 0x1,        //read
-       RESTART_STREAM_BIT = 0x1        //write
+       HALTED_STATUS_BIT = 0x1,        // read
+       RESTART_STREAM_BIT = 0x1        // write
 };
 
 enum buffer_control_bits {
        DIRECTION_GPIB_TO_HOST_BIT = 0x20,      // transfer direction (set for gpib to host)
-       ENABLE_TI_BUFFER_BIT = 0x40,    //enable fifo
-       FAST_WR_EN_BIT = 0x80,  // 350 ns t1 delay?
+       ENABLE_TI_BUFFER_BIT = 0x40,            // enable fifo
+       FAST_WR_EN_BIT = 0x80,                  // 350 ns t1 delay?
 };
 
 // registers accessible through isapnp chip on 82341d
 enum hp_82341d_pnp_registers {
-       PIO_DATA_REG = 0x20,    //read/write pio data lines
+       PIO_DATA_REG = 0x20,            // read/write pio data lines
        PIO_DIRECTION_REG = 0x21,       // set pio data line directions (set for input)
 };
 
index 4de0f6797458477cfd5ed7235f743348305ed2f7..d7f63c7950963a37e3b24e80350a1c957ece6c0f 100644 (file)
@@ -24,7 +24,7 @@ extern inline int INCOMING_MAILBOX_REG(unsigned int mailbox)
 enum {
        OUTBOX_EMPTY_INTR_BIT = 0x10,   // enable outbox empty interrupt
        INBOX_FULL_INTR_BIT = 0x1000,   // enable inbox full interrupt
-       INBOX_INTR_CS_BIT = 0x20000, // read, or write clear inbox full interrupt
+       INBOX_INTR_CS_BIT = 0x20000,    // read, or write clear inbox full interrupt
        INTR_ASSERTED_BIT = 0x800000,   // read only, interrupt asserted
 };
 
@@ -52,7 +52,7 @@ extern inline int OUTBOX_SELECT_BITS(unsigned int mailbox)
        return (mailbox & 0x3) << 2;
 };
 
-//BMCSR bits
+// BMCSR bits
 enum {
        MBOX_FLAGS_RESET_BIT = 0x08000000,      // resets mailbox empty/full flags
 };
index db040c80d778416e92ff6a607217db356d4bb0ee..998abb379749f07d37560e4fa4ee45e21d5abf3e 100644 (file)
@@ -273,7 +273,8 @@ struct gpib_board {
        struct mutex big_gpib_mutex;
        /* pid of last process to lock the board mutex */
        pid_t locking_pid;
-       spinlock_t locking_pid_spinlock; // lock for setting locking pid
+       /* lock for setting locking pid */
+       spinlock_t locking_pid_spinlock;
        /* Spin lock for dealing with races with the interrupt handler */
        spinlock_t spinlock;
        /* Watchdog timer to enable timeouts */
index 312217b4580ea7b896622b83c7b21499b823286f..9835aa5ef4ffe48a17f7e93895efbaf3a1af2a72 100644 (file)
@@ -22,18 +22,18 @@ struct nec7210_priv {
        u32 iobase;
 #endif
        void __iomem *mmiobase;
-       unsigned int offset;    // offset between successive nec7210 io addresses
+       unsigned int offset;            // offset between successive nec7210 io addresses
        unsigned int dma_channel;
        u8 *dma_buffer;
        unsigned int dma_buffer_length; // length of dma buffer
        dma_addr_t dma_buffer_addr;     // bus address of board->buffer for use with dma
        // software copy of bits written to registers
        u8 reg_bits[8];
-       u8 auxa_bits;   // bits written to auxiliary register A
-       u8 auxb_bits;   // bits written to auxiliary register B
+       u8 auxa_bits;                   // bits written to auxiliary register A
+       u8 auxb_bits;                   // bits written to auxiliary register B
        // used to keep track of board's state, bit definitions given below
        unsigned long state;
-       /* lock for chips that extend the nec7210 registers by paging in alternate regs */
+       // lock for chips that extend the nec7210 registers by paging in alternate regs
        spinlock_t register_page_lock;
        // wrappers for outb, inb, readb, or writeb
        u8 (*read_byte)(struct nec7210_priv *priv, unsigned int register_number);
@@ -64,17 +64,17 @@ static inline void write_byte(struct nec7210_priv *priv, u8 byte, unsigned int r
 
 // struct nec7210_priv.state bit numbers
 enum {
-       PIO_IN_PROGRESS_BN,     // pio transfer in progress
+       PIO_IN_PROGRESS_BN,             // pio transfer in progress
        DMA_READ_IN_PROGRESS_BN,        // dma read transfer in progress
        DMA_WRITE_IN_PROGRESS_BN,       // dma write transfer in progress
-       READ_READY_BN,  // board has data byte available to read
-       WRITE_READY_BN, // board is ready to send a data byte
-       COMMAND_READY_BN,       // board is ready to send a command byte
-       RECEIVED_END_BN,        // received END
-       BUS_ERROR_BN,   // output error has occurred
-       RFD_HOLDOFF_BN, // rfd holdoff in effect
-       DEV_CLEAR_BN,   // device clear received
-       ADR_CHANGE_BN,  // address state change occurred
+       READ_READY_BN,                  // board has data byte available to read
+       WRITE_READY_BN,                 // board is ready to send a data byte
+       COMMAND_READY_BN,               // board is ready to send a command byte
+       RECEIVED_END_BN,                // received END
+       BUS_ERROR_BN,                   // output error has occurred
+       RFD_HOLDOFF_BN,                 // rfd holdoff in effect
+       DEV_CLEAR_BN,                   // device clear received
+       ADR_CHANGE_BN,                  // address state change occurred
 };
 
 // interface functions
index 97c53ac8e8058057f48bd069010d7a3cba5d96b1..067983d7a07f21eb79acd9d952173f917139726b 100644 (file)
@@ -11,7 +11,7 @@ enum nec7210_chipset {
        NEC7210,        // The original
        TNT4882,        // NI
        NAT4882,        // NI
-       CB7210, // measurement computing
+       CB7210,         // measurement computing
        IOT7210,        // iotech
        IGPIB7210,      // Ines
        TNT5004,        // NI (minor differences to TNT4882)
@@ -48,7 +48,7 @@ enum nec7210_read_regs {
        ADR1,   // address 2
 };
 
-//bit definitions common to nec-7210 compatible registers
+// bit definitions common to nec-7210 compatible registers
 
 // ISR1: interrupt status register 1
 enum isr1_bits {
index 66c56335f5c0b4aeeef29bed285b2a627dfc7792..c911b285a0ca5d4a33df5190a4f0c25a33368912 100644 (file)
@@ -23,10 +23,10 @@ enum plx9050_intcsr_bits {
        PLX9050_LINTR2_STATUS_BIT = 0x20,
        PLX9050_PCI_INTR_EN_BIT = 0x40,
        PLX9050_SOFT_INTR_BIT = 0x80,
-       PLX9050_LINTR1_SELECT_ENABLE_BIT = 0x100,       //9052 extension
-       PLX9050_LINTR2_SELECT_ENABLE_BIT = 0x200,       //9052 extension
-       PLX9050_LINTR1_EDGE_CLEAR_BIT = 0x400,  //9052 extension
-       PLX9050_LINTR2_EDGE_CLEAR_BIT = 0x800,  //9052 extension
+       PLX9050_LINTR1_SELECT_ENABLE_BIT = 0x100,       // 9052 extension
+       PLX9050_LINTR2_SELECT_ENABLE_BIT = 0x200,       // 9052 extension
+       PLX9050_LINTR1_EDGE_CLEAR_BIT = 0x400,          // 9052 extension
+       PLX9050_LINTR2_EDGE_CLEAR_BIT = 0x800,          // 9052 extension
 };
 
 enum plx9050_cntrl_bits {
index 50a9d3b226190267c6661ff99af8e9114789bb61..e66b75e0fda884876d7bd8093fd7c410c645739e 100644 (file)
@@ -30,10 +30,10 @@ struct tms9914_priv {
        u8 imr0_bits, imr1_bits;
        // bits written to address mode register
        u8 admr_bits;
-       u8 auxa_bits;   // bits written to auxiliary register A
+       u8 auxa_bits;           // bits written to auxiliary register A
        // used to keep track of board's state, bit definitions given below
        unsigned long state;
-       u8 eos; // eos character
+       u8 eos;                 // eos character
        short eos_flags;
        u8 spoll_status;
        enum tms9914_holdoff_mode holdoff_mode;
@@ -67,15 +67,15 @@ static inline void write_byte(struct tms9914_priv *priv, u8 byte, unsigned int r
 
 // struct tms9914_priv.state bit numbers
 enum {
-       PIO_IN_PROGRESS_BN,     // pio transfer in progress
+       PIO_IN_PROGRESS_BN,             // pio transfer in progress
        DMA_READ_IN_PROGRESS_BN,        // dma read transfer in progress
        DMA_WRITE_IN_PROGRESS_BN,       // dma write transfer in progress
-       READ_READY_BN,  // board has data byte available to read
-       WRITE_READY_BN, // board is ready to send a data byte
-       COMMAND_READY_BN,       // board is ready to send a command byte
-       RECEIVED_END_BN,        // received END
-       BUS_ERROR_BN,   // bus error
-       DEV_CLEAR_BN,   // device clear received
+       READ_READY_BN,                  // board has data byte available to read
+       WRITE_READY_BN,                 // board is ready to send a data byte
+       COMMAND_READY_BN,               // board is ready to send a command byte
+       RECEIVED_END_BN,                // received END
+       BUS_ERROR_BN,                   // bus error
+       DEV_CLEAR_BN,                   // device clear received
 };
 
 // interface functions
@@ -150,23 +150,23 @@ enum {
        IMR0 = 0,       /* interrupt mask 0          */
        IMR1 = 1,       /* interrupt mask 1          */
        AUXCR = 3,      /* auxiliary command         */
-       ADR = 4,        // address register
-       SPMR = 5,       // serial poll mode register
+       ADR = 4,        /* address register          */
+       SPMR = 5,       /* serial poll mode register */
        PPR = 6,        /* parallel poll             */
        CDOR = 7,       /* data out register         */
 };
 
 // read registers
 enum {
-       ISR0 = 0,       /* interrupt status 0          */
-       ISR1 = 1,       /* interrupt status 1          */
-       ADSR = 2,       /* address status               */
-       BSR = 3,        /* bus status */
-       CPTR = 6,       /* command pass thru           */
-       DIR = 7,        /* data in register            */
+       ISR0 = 0,       /* interrupt status 0        */
+       ISR1 = 1,       /* interrupt status 1        */
+       ADSR = 2,       /* address status            */
+       BSR = 3,        /* bus status                */
+       CPTR = 6,       /* command pass thru         */
+       DIR = 7,        /* data in register          */
 };
 
-//bit definitions common to tms9914 compatible registers
+// bit definitions common to tms9914 compatible registers
 
 /* ISR0   - Register bits */
 enum isr0_bits {
@@ -248,33 +248,33 @@ enum bus_status_bits {
 /*---------------------------------------------------------*/
 
 enum aux_cmd_bits {
-       AUX_CS = 0x80,  /* set bit instead of clearing it, used with commands marked 'd' below */
-       AUX_CHIP_RESET = 0x0,   /* d Chip reset                   */
-       AUX_INVAL = 0x1,        // release dac holdoff, invalid command byte
-       AUX_VAL = (AUX_INVAL | AUX_CS), // release dac holdoff, valid command byte
-       AUX_RHDF = 0x2, /* X Release RFD holdoff          */
-       AUX_HLDA = 0x3, /* d holdoff on all data          */
-       AUX_HLDE = 0x4, /* d holdoff on EOI only          */
-       AUX_NBAF = 0x5, /* X Set new byte available false */
-       AUX_FGET = 0x6, /* d force GET                    */
-       AUX_RTL = 0x7,  /* d return to local              */
-       AUX_SEOI = 0x8, /* X send EOI with next byte      */
-       AUX_LON = 0x9,  /* d Listen only                  */
-       AUX_TON = 0xa,  /* d Talk only                    */
-       AUX_GTS = 0xb,  /* X goto standby                 */
-       AUX_TCA = 0xc,  /* X take control asynchronously  */
-       AUX_TCS = 0xd,  /* X take    "     synchronously  */
-       AUX_RPP = 0xe,  /* d Request parallel poll        */
-       AUX_SIC = 0xf,  /* d send interface clear         */
-       AUX_SRE = 0x10, /* d send remote enable           */
-       AUX_RQC = 0x11, /* X request control              */
-       AUX_RLC = 0x12, /* X release control              */
-       AUX_DAI = 0x13, /* d disable all interrupts       */
-       AUX_PTS = 0x14, /* X pass through next secondary  */
-       AUX_STDL = 0x15,        /* d short T1 delay                 */
-       AUX_SHDW = 0x16,        /* d shadow handshake             */
-       AUX_VSTDL = 0x17,       /* d very short T1 delay (smj9914 extension) */
-       AUX_RSV2 = 0x18,        /* d request service bit 2 (smj9914 extension) */
+       AUX_CS = 0x80,                  /* set bit instead of clearing it, used with commands marked 'd' below */
+       AUX_CHIP_RESET = 0x0,           /* d Chip reset                   */
+       AUX_INVAL = 0x1,                /* release dac holdoff, invalid command byte */
+       AUX_VAL = (AUX_INVAL | AUX_CS), /* release dac holdoff, valid command byte   */
+       AUX_RHDF = 0x2,                 /* X Release RFD holdoff          */
+       AUX_HLDA = 0x3,                 /* d holdoff on all data          */
+       AUX_HLDE = 0x4,                 /* d holdoff on EOI only          */
+       AUX_NBAF = 0x5,                 /* X Set new byte available false */
+       AUX_FGET = 0x6,                 /* d force GET                    */
+       AUX_RTL = 0x7,                  /* d return to local              */
+       AUX_SEOI = 0x8,                 /* X send EOI with next byte      */
+       AUX_LON = 0x9,                  /* d Listen only                  */
+       AUX_TON = 0xa,                  /* d Talk only                    */
+       AUX_GTS = 0xb,                  /* X goto standby                 */
+       AUX_TCA = 0xc,                  /* X take control asynchronously  */
+       AUX_TCS = 0xd,                  /* X take    "     synchronously  */
+       AUX_RPP = 0xe,                  /* d Request parallel poll        */
+       AUX_SIC = 0xf,                  /* d send interface clear         */
+       AUX_SRE = 0x10,                 /* d send remote enable           */
+       AUX_RQC = 0x11,                 /* X request control              */
+       AUX_RLC = 0x12,                 /* X release control              */
+       AUX_DAI = 0x13,                 /* d disable all interrupts       */
+       AUX_PTS = 0x14,                 /* X pass through next secondary  */
+       AUX_STDL = 0x15,                /* d short T1 delay               */
+       AUX_SHDW = 0x16,                /* d shadow handshake             */
+       AUX_VSTDL = 0x17,               /* d very short T1 delay (smj9914 extension)   */
+       AUX_RSV2 = 0x18,                /* d request service bit 2 (smj9914 extension) */
 };
 
 #endif //_TMS9914_H
index 1b1441cd03d50ec23dca803be5853601b0d8addc..d54c4cc611682c4d0c9ca67e7664158529d6a09e 100644 (file)
@@ -32,11 +32,11 @@ enum {
        CMDR = 0x1c,    // command register
        TIMER = 0x1e,   // timer register
 
-       STS1 = 0x10,            /* T488 Status Register 1 */
-       STS2 = 0x1c,            /* T488 Status Register 2 */
+       STS1 = 0x10,    // T488 Status Register 1
+       STS2 = 0x1c,    // T488 Status Register 2
        ISR0 = IMR0,
-       ISR3 = 0x1a,            /* T488 Interrupt Status Register 3 */
-       BCR = 0x1f,             /* bus control/status register */
+       ISR3 = 0x1a,    // T488 Interrupt Status Register 3
+       BCR = 0x1f,     // bus control/status register
        BSR = BCR,
 };
 
@@ -107,11 +107,11 @@ enum imr0_bits {
 
 /* ISR0 -- Interrupt Status Register 0 */
 enum isr0_bits {
-       TNT_SYNC_BIT = 0x1, /* handshake sync */
-       TNT_TO_BIT = 0x2, /* timeout */
-       TNT_ATNI_BIT = 0x4, /* ATN interrupt */
+       TNT_SYNC_BIT = 0x1,     /* handshake sync */
+       TNT_TO_BIT = 0x2,       /* timeout */
+       TNT_ATNI_BIT = 0x4,     /* ATN interrupt */
        TNT_IFCI_BIT = 0x8,     /* interface clear interrupt */
-       TNT_EOS_BIT = 0x10, /* end of string */
+       TNT_EOS_BIT = 0x10,     /* end of string */
        TNT_NL_BIT = 0x20,      /* new line receive */
        TNT_STBO_BIT = 0x40,    /* status byte out  */
        TNT_NBA_BIT = 0x80,     /* new byte available */
@@ -129,7 +129,7 @@ enum isr3_bits {
 };
 
 enum keyreg_bits {
-       MSTD = 0x20,    // enable 350ns T1 delay
+       MSTD = 0x20,    /* enable 350ns T1 delay */
 };
 
 /* STS1 -- Status Register 1 (read only) */
@@ -157,7 +157,7 @@ enum tnt4882_aux_cmds {
        AUX_9914 = 0x15,        // switch to 9914 mode
        AUX_REQT = 0x18,
        AUX_REQF = 0x19,
-       AUX_PAGEIN = 0x50,      /* page in alternate registers */
+       AUX_PAGEIN = 0x50,      // page in alternate registers
        AUX_HLDI = 0x51,        // rfd holdoff immediately
        AUX_CLEAR_END = 0x55,
        AUX_7210 = 0x99,        // switch to 7210 mode
@@ -183,7 +183,7 @@ enum auxi_bits {
 
 enum sasr_bits {
        ACRDY_BIT = 0x4,        /* acceptor ready state */
-       ADHS_BIT = 0x8, /* acceptor data holdoff state */
+       ADHS_BIT = 0x8,         /* acceptor data holdoff state */
        ANHS2_BIT = 0x10,       /* acceptor not ready holdoff immediately state */
        ANHS1_BIT = 0x20,       /* acceptor not ready holdoff state */
        AEHS_BIT = 0x40,        /* acceptor end holdoff state */
index f0210ce2470da3a6978e448a07693e95c8275837..6ad57e9a121669a65a22723bd6eabff944f665ee 100644 (file)
@@ -97,9 +97,9 @@ enum extend_mode_bits {
        TR3_TRIG_ENABLE_BIT = 0x1,      // enable generation of trigger pulse T/R3 pin
        // clear message available status bit when chip writes byte with EOI true
        MAV_ENABLE_BIT = 0x2,
-       EOS1_ENABLE_BIT = 0x4,  // enable eos register 1
-       EOS2_ENABLE_BIT = 0x8,  // enable eos register 2
-       EOIDIS_BIT = 0x10,      // disable EOI interrupt when doing rfd holdoff on end?
+       EOS1_ENABLE_BIT = 0x4,          // enable eos register 1
+       EOS2_ENABLE_BIT = 0x8,          // enable eos register 2
+       EOIDIS_BIT = 0x10,              // disable EOI interrupt when doing rfd holdoff on end?
        XFER_COUNTER_ENABLE_BIT = 0x20,
        XFER_COUNTER_OUTPUT_BIT = 0x40, // use counter for output, clear for input
        // when xfer counter hits 0, assert EOI on write or RFD holdoff on read
@@ -121,10 +121,10 @@ enum ines_admr_bits {
 };
 
 enum xdma_control_bits {
-       DMA_OUTPUT_BIT = 0x1,   // use dma for output, clear for input
+       DMA_OUTPUT_BIT = 0x1,           // use dma for output, clear for input
        ENABLE_SYNC_DMA_BIT = 0x2,
-       DMA_ACCESS_EVERY_CYCLE = 0x4,// dma accesses fifo every cycle, clear for every other cycle
-       DMA_16BIT = 0x8,        // clear for 8 bit transfers
+       DMA_ACCESS_EVERY_CYCLE = 0x4,   // dma accesses fifo every cycle, clear for every other cycle
+       DMA_16BIT = 0x8,                // clear for 8 bit transfers
 };
 
 enum bus_control_monitor_bits {
index c851fd014f487c0a75a3e398b2cc567b37b69535..a3cf846fd0f942529b93e85903d9256b08495725 100644 (file)
@@ -152,7 +152,7 @@ static int ines_accel_read(struct gpib_board *board, u8 *buffer,
 
        write_byte(nec_priv, INES_RFD_HLD_IMMEDIATE, AUXMR);
 
-       //clear in fifo
+       // clear in fifo
        nec7210_set_reg_bits(nec_priv, ADMR, IN_FIFO_ENABLE_BIT, 0);
        nec7210_set_reg_bits(nec_priv, ADMR, IN_FIFO_ENABLE_BIT, IN_FIFO_ENABLE_BIT);
 
@@ -225,7 +225,7 @@ static int ines_accel_write(struct gpib_board *board, u8 *buffer, size_t length,
        unsigned int num_bytes, i;
 
        *bytes_written = 0;
-       //clear out fifo
+       // clear out fifo
        nec7210_set_reg_bits(nec_priv, ADMR, OUT_FIFO_ENABLE_BIT, 0);
        nec7210_set_reg_bits(nec_priv, ADMR, OUT_FIFO_ENABLE_BIT, OUT_FIFO_ENABLE_BIT);
 
index 34a1cae4f4864e6e1ae2c74683d0d12ebd4d742e..bbf39367f5e4f055a0cc0e2d0fe5e9279cfd7be7 100644 (file)
@@ -779,10 +779,10 @@ int nec7210_write(struct gpib_board *board, struct nec7210_priv *priv,
 
        *bytes_written = 0;
 
-       clear_bit(DEV_CLEAR_BN, &priv->state); //XXX
+       clear_bit(DEV_CLEAR_BN, &priv->state); // XXX
 
        if (send_eoi)
-               length-- ; /* save the last byte for sending EOI */
+               length-- ; // save the last byte for sending EOI
 
        if (length > 0) {
                // isa dma transfer
@@ -1005,7 +1005,7 @@ void nec7210_board_online(struct nec7210_priv *priv, const struct gpib_board *bo
        nec7210_primary_address(board, priv, board->pad);
        nec7210_secondary_address(board, priv, board->sad, board->sad >= 0);
 
-       // enable interrupts
+       /* enable interrupts */
        priv->reg_bits[IMR1] = HR_ERRIE | HR_DECIE | HR_ENDIE |
                HR_DETIE | HR_CPTIE | HR_DOIE | HR_DIIE;
        priv->reg_bits[IMR2] = IMR2_ENABLE_INTR_MASK;
index 73ea72f34c0a33a2276aaf95a939ba52fdf84282..4dec87d12687a1523009c5a7a7f41be2143c5de3 100644 (file)
@@ -29,7 +29,7 @@ static void ni_usb_stop(struct ni_usb_priv *ni_priv);
 
 static DEFINE_MUTEX(ni_usb_hotplug_lock);
 
-//calculates a reasonable timeout in that can be passed to usb functions
+// calculates a reasonable timeout in that can be passed to usb functions
 static inline unsigned long ni_usb_timeout_msecs(unsigned int usec)
 {
        if (usec == 0)
@@ -327,7 +327,7 @@ static void ni_usb_soft_update_status(struct gpib_board *board, unsigned int ni_
        board->status &= ~clear_mask;
        board->status &= ~ni_usb_ibsta_mask;
        board->status |= ni_usb_ibsta & ni_usb_ibsta_mask;
-       //FIXME should generate events on DTAS and DCAS
+       // FIXME should generate events on DTAS and DCAS
 
        spin_lock_irqsave(&board->spinlock, flags);
 /* remove set status bits from monitored set why ?***/
@@ -569,7 +569,7 @@ static int ni_usb_write_registers(struct ni_usb_priv *ni_priv,
        mutex_unlock(&ni_priv->addressed_transfer_lock);
 
        ni_usb_parse_reg_write_status_block(in_data, &status, &reg_writes_completed);
-       //FIXME parse extra 09 status bits and termination
+       // FIXME parse extra 09 status bits and termination
        kfree(in_data);
        if (status.id != NIUSB_REG_WRITE_ID) {
                dev_err(&usb_dev->dev, "parse error, id=0x%x != NIUSB_REG_WRITE_ID\n", status.id);
@@ -1106,7 +1106,7 @@ static int ni_usb_request_system_control(struct gpib_board *board, int request_c
        return 0;
 }
 
-//FIXME maybe the interface should have a "pulse interface clear" function that can return an error?
+// FIXME maybe the interface should have a "pulse interface clear" function that can return an error?
 static void ni_usb_interface_clear(struct gpib_board *board, int assert)
 {
        int retval;
@@ -1363,7 +1363,7 @@ static int ni_usb_parallel_poll(struct gpib_board *board, u8 *result)
                return -ENOMEM;
 
        out_data[i++] = NIUSB_IBRPP_ID;
-       out_data[i++] = 0xf0;   //FIXME: this should be the parallel poll timeout code
+       out_data[i++] = 0xf0;   // FIXME: this should be the parallel poll timeout code
        out_data[i++] = 0x0;
        out_data[i++] = 0x0;
        i += ni_usb_bulk_termination(&out_data[i]);
index b011e131201c1927bbdaf82263ec96d1845e8de8..688f5e08792fc621a288c6dd219275864b0aae00 100644 (file)
@@ -72,10 +72,10 @@ struct ni_usb_priv {
        struct urb *bulk_urb;
        struct urb *interrupt_urb;
        u8 interrupt_buffer[0x11];
-       struct mutex addressed_transfer_lock; // protect transfer lock
-       struct mutex bulk_transfer_lock;  // protect bulk message sends
-       struct mutex control_transfer_lock; // protect control messages
-       struct mutex interrupt_transfer_lock; //  protect interrupt messages
+       struct mutex addressed_transfer_lock;   // protect transfer lock
+       struct mutex bulk_transfer_lock;        // protect bulk message sends
+       struct mutex control_transfer_lock;     // protect control messages
+       struct mutex interrupt_transfer_lock;   //  protect interrupt messages
        struct timer_list bulk_timer;
        struct ni_usb_urb_ctx context;
        int product_id;
@@ -145,7 +145,7 @@ enum ni_usb_error_codes {
         * CIC with no listener
         */
        NIUSB_NO_LISTENER_ERROR = 8,
-       // get NIUSB_TIMEOUT_ERROR on board read/write timeout
+       /* get NIUSB_TIMEOUT_ERROR on board read/write timeout */
        NIUSB_TIMEOUT_ERROR = 10,
 };
 
index 2282492025b78db6a966cbee5a4fb078f605bcfe..9f3943d1df666cb20817b12843a272e6cfd56bd1 100644 (file)
@@ -36,7 +36,7 @@ static const int pc2_2a_iosize = 16;
 static const int pc2a_reg_offset = 0x400;
 static const int pc2_reg_offset = 1;
 
-//interrupt service routine
+// interrupt service routine
 static irqreturn_t pc2_interrupt(int irq, void *arg);
 static irqreturn_t pc2a_interrupt(int irq, void *arg);
 
@@ -593,7 +593,7 @@ static struct gpib_interface pc2a_cb7210_interface = {
        .parallel_poll_configure =      pc2_parallel_poll_configure,
        .parallel_poll_response =       pc2_parallel_poll_response,
        .local_parallel_poll_mode = NULL, // XXX
-       .line_status =  NULL, //XXX
+       .line_status =  NULL, // XXX
        .update_status =        pc2_update_status,
        .primary_address =      pc2_primary_address,
        .secondary_address =    pc2_secondary_address,
index 04d57108efc740b3084c4b8bbbecdb719e4934f1..0d11b80bb9829dbce2c47fd34976e58d0ab1bb30 100644 (file)
@@ -647,7 +647,7 @@ static void check_my_address_state(struct gpib_board *board,
        } else if (cmd_byte == MTA(board->pad)) {
                priv->primary_talk_addressed = 1;
                if (board->sad < 0)
-                       //make active talker
+                       // make active talker
                        write_byte(priv, AUX_TON | AUX_CS, AUXCR);
        } else if (board->sad >= 0 && priv->primary_talk_addressed &&
                   cmd_byte == MSA(board->sad)) {
@@ -730,7 +730,7 @@ irqreturn_t tms9914_interrupt_have_status(struct gpib_board *board, struct tms99
        if (status0 & HR_SPAS) {
                priv->spoll_status &= ~request_service_bit;
                write_byte(priv, priv->spoll_status, SPMR);
-               //FIXME: set SPOLL status bit
+               // FIXME: set SPOLL status bit
        }
        // record service request in status
        if (status1 & HR_SRQ)
@@ -841,7 +841,7 @@ void tms9914_board_reset(struct tms9914_priv *priv)
 
        /* parallel poll unconfigure */
        write_byte(priv, 0, PPR);
-       // request for data holdoff
+       /* request for data holdoff */
        tms9914_set_holdoff_mode(priv, TMS9914_HOLDOFF_ALL);
 }
 EXPORT_SYMBOL_GPL(tms9914_board_reset);
@@ -852,7 +852,7 @@ void tms9914_online(struct gpib_board *board, struct tms9914_priv *priv)
        tms9914_primary_address(board, priv, board->pad);
        tms9914_secondary_address(board, priv, board->sad, board->sad >= 0);
 
-       // enable tms9914 interrupts
+       /* enable tms9914 interrupts */
        priv->imr0_bits |= HR_MACIE | HR_RLCIE | HR_ENDIE | HR_BOIE | HR_BIIE |
                HR_SPASIE;
        priv->imr1_bits |= HR_MAIE | HR_SRQIE | HR_UNCIE | HR_ERRIE | HR_IFCIE |
@@ -861,7 +861,7 @@ void tms9914_online(struct gpib_board *board, struct tms9914_priv *priv)
        write_byte(priv, priv->imr1_bits, IMR1);
        write_byte(priv, AUX_DAI, AUXCR);
 
-       // turn off reset state
+       /* turn off reset state */
        write_byte(priv, AUX_CHIP_RESET, AUXCR);
 }
 EXPORT_SYMBOL_GPL(tms9914_online);
index 522d6b56cb7d7dbde3ceaa32d7c18a2a26b6f1c9..a1fdba9672a03830e2ddb672b51dd4b82127455b 100644 (file)
@@ -219,15 +219,15 @@ void mite_list_devices(void);
 #define MITE_AMHOST_A24_BLOCK          0x3b
 
 enum mite_registers {
-       MITE_IODWBSR = 0xc0, //IO Device Window Base Size Register
-       MITE_CSIGR = 0x460,     //chip signature
-       MITE_IODWBSR_1 = 0xc4, // IO Device Window Base Size Register 1 (used by 6602 boards)
+       MITE_IODWBSR = 0xc0,    // IO Device Window Base Size Register
+       MITE_CSIGR = 0x460,     // chip signature
+       MITE_IODWBSR_1 = 0xc4,  // IO Device Window Base Size Register 1 (used by 6602 boards)
        MITE_IODWCR_1 = 0xf4
 };
 
 enum MITE_IODWBSR_bits {
-       WENAB = 0x80,   // window enable
-       WENAB_6602 = 0x8c // window enable for 6602 boards
+       WENAB = 0x80,           // window enable
+       WENAB_6602 = 0x8c       // window enable for 6602 boards
 };
 
 #endif
index a17b69e349867942fbcad27823bed87e10ce6a4b..29c6884e01fd95151ec5c6461fbc4d3bbafb6b30 100644 (file)
@@ -570,7 +570,7 @@ static irqreturn_t tnt4882_internal_interrupt(struct gpib_board *board)
 
        if (isr0_bits & TNT_IFCI_BIT)
                push_gpib_event(board, EVENT_IFC);
-       //XXX don't need this wakeup, one below should do?
+       // XXX don't need this wakeup, one below should do?
 //             wake_up_interruptible(&board->wait);
 
        if (isr3_bits & HR_NFF)
@@ -730,7 +730,7 @@ static int tnt4882_parallel_poll(struct gpib_board *board, u8 *result)
        if (tnt_priv->nec7210_priv.type != NEC7210) {
                tnt_priv->auxg_bits |= RPP2_BIT;
                write_byte(&tnt_priv->nec7210_priv, tnt_priv->auxg_bits, AUXMR);
-               udelay(2);      //FIXME use parallel poll timeout
+               udelay(2);      // FIXME use parallel poll timeout
                *result = read_byte(&tnt_priv->nec7210_priv, CPTR);
                tnt_priv->auxg_bits &= ~RPP2_BIT;
                write_byte(&tnt_priv->nec7210_priv, tnt_priv->auxg_bits, AUXMR);