]> www.infradead.org Git - users/hch/misc.git/commitdiff
net: amd: mvme147: Fix probe banner message
authorDaniel Palmer <daniel@0x0f.com>
Mon, 7 Oct 2024 10:43:17 +0000 (19:43 +0900)
committerDavid S. Miller <davem@davemloft.net>
Wed, 9 Oct 2024 11:45:51 +0000 (12:45 +0100)
Currently this driver prints this line with what looks like
a rogue format specifier when the device is probed:
[    2.840000] eth%d: MVME147 at 0xfffe1800, irq 12, Hardware Address xx:xx:xx:xx:xx:xx

Change the printk() for netdev_info() and move it after the
registration has completed so it prints out the name of the
interface properly.

Signed-off-by: Daniel Palmer <daniel@0x0f.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/amd/mvme147.c

index c156566c09064c4904643e566a99a4cf5c218ef1..f19b04b92fa9f3870dd56dc0868206e45c709286 100644 (file)
@@ -105,10 +105,6 @@ static struct net_device * __init mvme147lance_probe(void)
        macaddr[3] = address&0xff;
        eth_hw_addr_set(dev, macaddr);
 
-       printk("%s: MVME147 at 0x%08lx, irq %d, Hardware Address %pM\n",
-              dev->name, dev->base_addr, MVME147_LANCE_IRQ,
-              dev->dev_addr);
-
        lp = netdev_priv(dev);
        lp->ram = __get_dma_pages(GFP_ATOMIC, 3);       /* 32K */
        if (!lp->ram) {
@@ -138,6 +134,9 @@ static struct net_device * __init mvme147lance_probe(void)
                return ERR_PTR(err);
        }
 
+       netdev_info(dev, "MVME147 at 0x%08lx, irq %d, Hardware Address %pM\n",
+                   dev->base_addr, MVME147_LANCE_IRQ, dev->dev_addr);
+
        return dev;
 }