]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
hwmon: (tmp108) Do not fail in I3C probe when I3C regmap is a module
authorJarkko Nikula <jarkko.nikula@linux.intel.com>
Thu, 21 Nov 2024 12:18:19 +0000 (14:18 +0200)
committerGuenter Roeck <linux@roeck-us.net>
Sat, 23 Nov 2024 17:49:02 +0000 (09:49 -0800)
I3C device probe fails when CONFIG_REGMAP_I3C=m:

p3t1085_i3c 0-23615290090: error -ENODEV: Failed to register i3c regmap

Fix this by using the IS_ENABLED(CONFIG_REGMAP_I3C) macro in the code.

Fixes: c40655e33106 ("hwmon: (tmp108) Add support for I3C device")
Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Message-ID: <20241121121819.393104-1-jarkko.nikula@linux.intel.com>
[groeck: Remove #ifdef entirely; it is not needed due to dead code elimination]
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/tmp108.c

index 1f36af2cd2d94f1b02a02539b1dc1092d0d06cac..fbe673009126115f710dcc3258ca7a2a61fb7206 100644 (file)
@@ -452,12 +452,7 @@ static int p3t1085_i3c_probe(struct i3c_device *i3cdev)
        struct device *dev = i3cdev_to_dev(i3cdev);
        struct regmap *regmap;
 
-#ifdef CONFIG_REGMAP_I3C
        regmap = devm_regmap_init_i3c(i3cdev, &tmp108_regmap_config);
-#else
-       regmap = ERR_PTR(-ENODEV);
-#endif
-
        if (IS_ERR(regmap))
                return dev_err_probe(dev, PTR_ERR(regmap),
                                     "Failed to register i3c regmap\n");