net: pxa168_eth: Adjust four checks for null pointers

MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The script “checkpatch.pl” pointed information out like the following.

Comparison to NULL could be written …

Thus fix the affected source code places.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/marvell/pxa168_eth.c b/drivers/net/ethernet/marvell/pxa168_eth.c
index 2404eac51c6360cacb8c7a36a1919498321ed5ec..993724959a7c32468646ae934605ba3ad81d9d1a 100644 (file)
--- a/drivers/net/ethernet/marvell/pxa168_eth.c
+++ b/drivers/net/ethernet/marvell/pxa168_eth.c
@@ -556,11 +556,11 @@ static int init_hash_table(struct pxa168_eth_private *pep)
         * function.Driver can dynamically switch to them if the 1/2kB hash
         * table is full.
         */
-       if (pep->htpr == NULL) {
+       if (!pep->htpr) {
                pep->htpr = dma_zalloc_coherent(pep->dev->dev.parent,
                                                HASH_ADDR_TABLE_SIZE,
                                                &pep->htpr_dma, GFP_KERNEL);
-               if (pep->htpr == NULL)
+               if (!pep->htpr)
                        return -ENOMEM;
        } else {
                memset(pep->htpr, 0, HASH_ADDR_TABLE_SIZE);
@@ -1356,7 +1356,7 @@ static int pxa168_smi_write(struct mii_bus *bus, int phy_addr, int regnum,
 static int pxa168_eth_do_ioctl(struct net_device *dev, struct ifreq *ifr,
                               int cmd)
 {
-       if (dev->phydev != NULL)
+       if (dev->phydev)
                return phy_mii_ioctl(dev->phydev, ifr, cmd);
 
        return -EOPNOTSUPP;
@@ -1501,7 +1501,7 @@ static int pxa168_eth_probe(struct platform_device *pdev)
        pep->timeout.data = (unsigned long)pep;
 
        pep->smi_bus = mdiobus_alloc();
-       if (pep->smi_bus == NULL) {
+       if (!pep->smi_bus) {
                err = -ENOMEM;
                goto err_netdev;
        }