]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
iio: adis_buffer: do not return ints in irq handlers
authorNuno Sa <nuno.sa@analog.com>
Thu, 22 Apr 2021 10:19:03 +0000 (12:19 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Jul 2021 14:53:36 +0000 (16:53 +0200)
[ Upstream commit d877539ad8e8fdde9af69887055fec6402be1a13 ]

On an IRQ handler we should not return normal error codes as 'irqreturn_t'
is expected.

Not necessarily stable material as the old check cannot fail, so it's a bug
we can not hit.

Fixes: ccd2b52f4ac69 ("staging:iio: Add common ADIS library")
Reviewed-by: Alexandru Ardelean <ardeleanalex@gmail.com>
Signed-off-by: Nuno Sa <nuno.sa@analog.com>
Link: https://lore.kernel.org/r/20210422101911.135630-2-nuno.sa@analog.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/iio/imu/adis_buffer.c

index 4998a89d083d54d4b6dafd2ccb9b3d825d2447e9..8f8c1a87567b25560d0b00b9fa893aeb1e888aee 100644 (file)
@@ -125,9 +125,6 @@ static irqreturn_t adis_trigger_handler(int irq, void *p)
        struct adis *adis = iio_device_get_drvdata(indio_dev);
        int ret;
 
-       if (!adis->buffer)
-               return -ENOMEM;
-
        if (adis->data->has_paging) {
                mutex_lock(&adis->txrx_lock);
                if (adis->current_page != 0) {