]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
PCI: qcom-ep: Treat unknown IRQ events as an error
authorManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Wed, 26 Jul 2023 15:29:31 +0000 (20:59 +0530)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Tue, 29 Aug 2023 11:59:35 +0000 (11:59 +0000)
Sometimes, the Qcom PCIe EP controller can receive some interrupts
unknown to the driver, like safety interrupts in newer SoCs. In those
cases, if the driver doesn't clear the interrupts, it will end up in an
interrupt storm. However, the users will not know about it because the
log is treated as a debug message.

So let's treat the unknown event log as an error so that it at least
makes the user aware, thereby getting fixed eventually.

[kwilczynski: commit log]
Link: https://lore.kernel.org/linux-pci/20230726152931.18134-1-manivannan.sadhasivam@linaro.org
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
drivers/pci/controller/dwc/pcie-qcom-ep.c

index 0fe7f06f21026d1a85b87324150a40f9d575c0f0..86929a7a104e59bd212ee362b68f5345bfdafa0d 100644 (file)
@@ -593,7 +593,7 @@ static irqreturn_t qcom_pcie_ep_global_irq_thread(int irq, void *data)
                dw_pcie_ep_linkup(&pci->ep);
                pcie_ep->link_status = QCOM_PCIE_EP_LINK_UP;
        } else {
-               dev_dbg(dev, "Received unknown event: %d\n", status);
+               dev_err(dev, "Received unknown event: %d\n", status);
        }
 
        return IRQ_HANDLED;