]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
nfsd: remove unneeded EEXIST error check in nfsd_do_file_acquire
authorJeff Layton <jlayton@kernel.org>
Thu, 11 Jul 2024 19:11:13 +0000 (15:11 -0400)
committerChuck Lever <chuck.lever@oracle.com>
Sun, 1 Sep 2024 14:04:54 +0000 (10:04 -0400)
Given that we do the search and insertion while holding the i_lock, I
don't think it's possible for us to get EEXIST here. Remove this case.

Fixes: c6593366c0bf ("nfsd: don't kill nfsd_files because of lease break error")
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Tested-by: Youzhong Yang <youzhong@gmail.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/filecache.c

index 01d76f6bc80a0a96ca3a03695280e9ed404b0398..9d7bb65b07463ac0e521b152e8a6581984449976 100644 (file)
@@ -1037,8 +1037,6 @@ retry:
        if (likely(ret == 0))
                goto open_file;
 
-       if (ret == -EEXIST)
-               goto retry;
        trace_nfsd_file_insert_err(rqstp, inode, may_flags, ret);
        status = nfserr_jukebox;
        goto construction_err;