]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
selftests: openvswitch: Attempt to autoload module.
authorAaron Conole <aconole@redhat.com>
Tue, 2 Jul 2024 13:28:29 +0000 (09:28 -0400)
committerJakub Kicinski <kuba@kernel.org>
Thu, 4 Jul 2024 02:29:15 +0000 (19:29 -0700)
Previously, the openvswitch.sh test suites would not attempt to autoload
the openvswitch module.  The idea was that a user who is manually running
tests might not even have the OVS module loaded or configured for their
own development.  However, if the kernel module is configured, and the
module can be autoloaded then we should just attempt to load it and run
the tests.  This is especially true in the CI environments, where the CI
tests should be able to rely on auto loading to get the test suite running.

Signed-off-by: Aaron Conole <aconole@redhat.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Tested-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240702132830.213384-3-aconole@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/openvswitch/openvswitch.sh

index 15bca07087179d7fff447784479e7fb4f913d866..0bd0425848d97f86f618a0bacc3e51be673c28c4 100755 (executable)
@@ -613,16 +613,20 @@ run_test() {
        tname="$1"
        tdesc="$2"
 
-       if ! lsmod | grep openvswitch >/dev/null 2>&1; then
-               stdbuf -o0 printf "TEST: %-60s  [NOMOD]\n" "${tdesc}"
-               return $ksft_skip
-       fi
-
        if python3 ovs-dpctl.py -h 2>&1 | \
             grep -E "Need to (install|upgrade) the python" >/dev/null 2>&1; then
                stdbuf -o0 printf "TEST: %-60s  [PYLIB]\n" "${tdesc}"
                return $ksft_skip
        fi
+
+       python3 ovs-dpctl.py show >/dev/null 2>&1 || \
+               echo "[DPCTL] show exception."
+
+       if ! lsmod | grep openvswitch >/dev/null 2>&1; then
+               stdbuf -o0 printf "TEST: %-60s  [NOMOD]\n" "${tdesc}"
+               return $ksft_skip
+       fi
+
        printf "TEST: %-60s  [START]\n" "${tname}"
 
        unset IFS