serial: qcom-geni: drop flip buffer WARN()

Drop the unnecessary WARN() in case the TTY buffers are ever full in
favour of a rate limited dev_err() which doesn't kill the machine when
panic_on_warn is set.

Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20241009145110.16847-8-johan+linaro@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
index 6c4349ea57202358d688812d9066b619e726805a..22e468065666304cee4c970fbffb17591f1936af 100644 (file)
--- a/drivers/tty/serial/qcom_geni_serial.c
+++ b/drivers/tty/serial/qcom_geni_serial.c
@@ -588,9 +588,8 @@ static void handle_rx_uart(struct uart_port *uport, u32 bytes, bool drop)
 
        ret = tty_insert_flip_string(tport, port->rx_buf, bytes);
        if (ret != bytes) {
-               dev_err(uport->dev, "%s:Unable to push data ret %d_bytes %d\n",
-                               __func__, ret, bytes);
-               WARN_ON_ONCE(1);
+               dev_err_ratelimited(uport->dev, "failed to push data (%d < %u)\n",
+                               ret, bytes);
        }
        uport->icount.rx += ret;
        tty_flip_buffer_push(tport);