]> www.infradead.org Git - users/willy/linux.git/commitdiff
usbip: Correct format specifier for seqnum from %d to %u
authorXiong Nandi <xndchn@gmail.com>
Tue, 31 Dec 2024 16:15:38 +0000 (00:15 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 Jan 2025 11:38:01 +0000 (12:38 +0100)
The seqnum field in USBIP protocol is an unsigned value.
So we fix the format specifier from %d to %u to correctly
display the value.

Signed-off-by: Xiong Nandi <xndchn@gmail.com>
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
Link: https://lore.kernel.org/r/20241231161539.20192-3-xndchn@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/usbip/stub_rx.c
drivers/usb/usbip/stub_tx.c
drivers/usb/usbip/vhci_rx.c
drivers/usb/usbip/vudc_tx.c

index 6338d818bc8bc9b4fe20c2d19682d4f5a68912e1..9aa30ef76f3bc480d1f9b2b822f2a3eeee4b0a55 100644 (file)
@@ -269,7 +269,7 @@ static int stub_recv_cmd_unlink(struct stub_device *sdev,
                return 0;
        }
 
-       usbip_dbg_stub_rx("seqnum %d is not pending\n",
+       usbip_dbg_stub_rx("seqnum %u is not pending\n",
                          pdu->u.cmd_unlink.seqnum);
 
        /*
index b1c2f6781cb33046ae39a8692aee0f453d93fdb3..7eb2e074012a4c59f10a5f64a12d0a3ed18a3e97 100644 (file)
@@ -201,7 +201,7 @@ static int stub_send_ret_submit(struct stub_device *sdev)
 
                /* 1. setup usbip_header */
                setup_ret_submit_pdu(&pdu_header, urb);
-               usbip_dbg_stub_tx("setup txdata seqnum: %d\n",
+               usbip_dbg_stub_tx("setup txdata seqnum: %u\n",
                                  pdu_header.base.seqnum);
 
                if (priv->sgl) {
index 7f2d1c241559face9a47f8606e0cd8f237ba2ed5..a75f4a898a4127a1844aca28c99fdd4a3b22a5ea 100644 (file)
@@ -66,7 +66,7 @@ static void vhci_recv_ret_submit(struct vhci_device *vdev,
        spin_unlock_irqrestore(&vdev->priv_lock, flags);
 
        if (!urb) {
-               pr_err("cannot find a urb of seqnum %u max seqnum %d\n",
+               pr_err("cannot find a urb of seqnum %u max seqnum %u\n",
                        pdu->base.seqnum,
                        atomic_read(&vhci_hcd->seqnum));
                usbip_event_add(ud, VDEV_EVENT_ERROR_TCP);
@@ -162,10 +162,10 @@ static void vhci_recv_ret_unlink(struct vhci_device *vdev,
                 * already received the result of its submit result and gave
                 * back the URB.
                 */
-               pr_info("the urb (seqnum %d) was already given back\n",
+               pr_info("the urb (seqnum %u) was already given back\n",
                        pdu->base.seqnum);
        } else {
-               usbip_dbg_vhci_rx("now giveback urb %d\n", pdu->base.seqnum);
+               usbip_dbg_vhci_rx("now giveback urb %u\n", pdu->base.seqnum);
 
                /* If unlink is successful, status is -ECONNRESET */
                urb->status = pdu->u.ret_unlink.status;
index 3ccb17c3e84060a907afb8c2914e3f69039f753d..30c11bf9f4e7ba13f1ac3a0b0b946e5d6237d0c4 100644 (file)
@@ -107,7 +107,7 @@ static int v_send_ret_submit(struct vudc *udc, struct urbp *urb_p)
 
        /* 1. setup usbip_header */
        setup_ret_submit_pdu(&pdu_header, urb_p);
-       usbip_dbg_stub_tx("setup txdata seqnum: %d\n",
+       usbip_dbg_stub_tx("setup txdata seqnum: %u\n",
                          pdu_header.base.seqnum);
        usbip_header_correct_endian(&pdu_header, 1);