wifi: mac80211: fix BSS_CHANGED_UNSOL_BCAST_PROBE_RESP

Fix the definition of BSS_CHANGED_UNSOL_BCAST_PROBE_RESP so that
not all higher bits get set, 1<<31 is a signed variable, so when
we do

  u64 changed = BSS_CHANGED_UNSOL_BCAST_PROBE_RESP;

we get sign expansion, so the value is 0xffff'ffff'8000'0000 and
that's clearly not desired. Use BIT_ULL() to make it unsigned as
well as the right type for the change flags.

Fixes: 178e9d6adc43 ("wifi: mac80211: fix unsolicited broadcast probe config")
Reviewed-by: Miriam Rachel Korenblit <miriam.rachel.korenblit@intel.com>
Link: https://patch.msgid.link/20240627104257.06174d291db2.Iba0d642916eb78a61f8ab2cc5ca9280783d9c1db@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

diff --git a/include/net/mac80211.h b/include/net/mac80211.h
index cafc664ee53185dd89104892ad66bbd962635651..45ad37adbe328722a885ef761a69ca26eedb9ce9 100644 (file)
--- a/include/net/mac80211.h
+++ b/include/net/mac80211.h
@@ -395,7 +395,7 @@ enum ieee80211_bss_change {
        BSS_CHANGED_HE_OBSS_PD          = 1<<28,
        BSS_CHANGED_HE_BSS_COLOR        = 1<<29,
        BSS_CHANGED_FILS_DISCOVERY      = 1<<30,
-       BSS_CHANGED_UNSOL_BCAST_PROBE_RESP = 1<<31,
+       BSS_CHANGED_UNSOL_BCAST_PROBE_RESP = BIT_ULL(31),
        BSS_CHANGED_MLD_VALID_LINKS     = BIT_ULL(33),
        BSS_CHANGED_MLD_TTLM            = BIT_ULL(34),