media: atomisp: atomisp_gmin_platform: check before use

solve this smatch warning:
	drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c:842 gmin_v1p8_ctrl() warn: variable dereferenced before check 'gs' (see line 832)

By moving the check to happen before its usage.

Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

diff --git a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
index 1ad0246764a66ed629a8394f8df211c62df109b4..135994d44802c70b3b6415cf38cd787261888f5e 100644 (file)
--- a/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_gmin_platform.c
@@ -817,6 +817,9 @@ static int gmin_v1p8_ctrl(struct v4l2_subdev *subdev, int on)
        int ret;
        int value;
 
+       if (!gs || gs->v1p8_on == on)
+               return 0;
+
        if (gs->v1p8_gpio >= 0) {
                pr_info("atomisp_gmin_platform: 1.8v power on GPIO %d\n",
                        gs->v1p8_gpio);
@@ -827,8 +830,6 @@ static int gmin_v1p8_ctrl(struct v4l2_subdev *subdev, int on)
                        pr_err("V1P8 GPIO initialization failed\n");
        }
 
-       if (!gs || gs->v1p8_on == on)
-               return 0;
        gs->v1p8_on = on;
 
        if (gs->v1p8_gpio >= 0)