media: imx335: Fix active area height discrepency

The imx335 reports a recommended pixel area of - 2592x1944.
The driver supported mode however limits it to height=1940.

Fix the height discrepency by correctly the value of height
(with updates to vblank and mode registers).

The IMX335_REG_HTRIMMING should also be corrected to the start
offset(i.e. 48) instead of chosing a abritrary crop start of 384.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c
index d07c7de5d22d64d946142d3ecdc64478c3f5b276..b206d17a57bcd6ab6d79d0a51715782d24e82f02 100644 (file)
--- a/drivers/media/i2c/imx335.c
+++ b/drivers/media/i2c/imx335.c
@@ -255,9 +255,9 @@ static const struct cci_reg_sequence mode_2592x1940_regs[] = {
        { IMX335_REG_MODE_SELECT, IMX335_MODE_STANDBY },
        { IMX335_REG_MASTER_MODE, 0x00 },
        { IMX335_REG_WINMODE, 0x04 },
-       { IMX335_REG_HTRIMMING_START, 384 },
+       { IMX335_REG_HTRIMMING_START, 48 },
        { IMX335_REG_HNUM, 2592 },
-       { IMX335_REG_Y_OUT_SIZE, 1940 },
+       { IMX335_REG_Y_OUT_SIZE, 1944 },
        { IMX335_REG_AREA3_ST_ADR_1, 176 },
        { IMX335_REG_AREA3_WIDTH_1, 3928 },
        { IMX335_REG_OPB_SIZE_V, 0 },
@@ -408,10 +408,10 @@ static const u32 imx335_mbus_codes[] = {
 /* Supported sensor mode configurations */
 static const struct imx335_mode supported_mode = {
        .width = 2592,
-       .height = 1940,
+       .height = 1944,
        .hblank = 342,
-       .vblank = 2560,
-       .vblank_min = 2560,
+       .vblank = 2556,
+       .vblank_min = 2556,
        .vblank_max = 133060,
        .pclk = 396000000,
        .reg_list = {