]> www.infradead.org Git - users/dwmw2/qemu.git/commitdiff
vl: Fail right after first bad -object
authorMarkus Armbruster <armbru@redhat.com>
Fri, 13 Mar 2015 12:08:36 +0000 (13:08 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Mon, 8 Jun 2015 17:33:20 +0000 (19:33 +0200)
Failure to create an object with -object is a fatal error.  However,
we delay the actual exit until all -object are processed.  On the one
hand, this permits detection of genuine additional errors.  On the
other hand, it can muddy the waters with uninteresting additional
errors, e.g. when a later -object tries to reference a prior one that
failed.

We generally stop right on the first bad option, so do that for
-object as well.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
vl.c

diff --git a/vl.c b/vl.c
index 680f4d82a5583a1c5057339d6c4a95fa69cc97ac..c9c3f33ce76870205b822125e44565a8434d414c 100644 (file)
--- a/vl.c
+++ b/vl.c
@@ -4055,7 +4055,7 @@ int main(int argc, char **argv, char **envp)
     }
 
     if (qemu_opts_foreach(qemu_find_opts("object"),
-                          object_create, NULL, 0) != 0) {
+                          object_create, NULL, 1) != 0) {
         exit(1);
     }