]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
pinctrl: imx: Switch to LATE_SYSTEM_SLEEP_PM_OPS()
authorFabio Estevam <festevam@denx.de>
Thu, 8 Aug 2024 16:27:50 +0000 (13:27 -0300)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 23 Aug 2024 16:15:52 +0000 (18:15 +0200)
Replace SET_LATE_SYSTEM_SLEEP_PM_OPS() with its modern
LATE_SYSTEM_SLEEP_PM_OPS() alternative.

The combined usage of pm_sleep_ptr() and LATE_SYSTEM_SLEEP_PM_OPS() allows
the compiler to evaluate if the runtime suspend/resume() functions
are used at build time or are simply dead code.

This allows removing the __maybe_unused notation from the runtime
suspend/resume() functions.

Signed-off-by: Fabio Estevam <festevam@denx.de>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Link: https://lore.kernel.org/20240808162750.244092-1-festevam@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/freescale/pinctrl-imx.c
drivers/pinctrl/freescale/pinctrl-imx8mq.c

index 9c2680df082c3137902f3ff43aa6d953559ce830..d05c2c478e7950d3a251cb7d41bc5cf3671b030d 100644 (file)
@@ -804,14 +804,14 @@ int imx_pinctrl_probe(struct platform_device *pdev,
 }
 EXPORT_SYMBOL_GPL(imx_pinctrl_probe);
 
-static int __maybe_unused imx_pinctrl_suspend(struct device *dev)
+static int imx_pinctrl_suspend(struct device *dev)
 {
        struct imx_pinctrl *ipctl = dev_get_drvdata(dev);
 
        return pinctrl_force_sleep(ipctl->pctl);
 }
 
-static int __maybe_unused imx_pinctrl_resume(struct device *dev)
+static int imx_pinctrl_resume(struct device *dev)
 {
        struct imx_pinctrl *ipctl = dev_get_drvdata(dev);
 
@@ -819,8 +819,7 @@ static int __maybe_unused imx_pinctrl_resume(struct device *dev)
 }
 
 const struct dev_pm_ops imx_pinctrl_pm_ops = {
-       SET_LATE_SYSTEM_SLEEP_PM_OPS(imx_pinctrl_suspend,
-                                       imx_pinctrl_resume)
+       LATE_SYSTEM_SLEEP_PM_OPS(imx_pinctrl_suspend, imx_pinctrl_resume)
 };
 EXPORT_SYMBOL_GPL(imx_pinctrl_pm_ops);
 
index 529eebe46298d2b3fabc8b491967da7fe42150c3..e59e4fc8019381bbe2afb59cb8e08941c8f418e5 100644 (file)
@@ -341,7 +341,7 @@ static struct platform_driver imx8mq_pinctrl_driver = {
        .driver = {
                .name = "imx8mq-pinctrl",
                .of_match_table = imx8mq_pinctrl_of_match,
-               .pm = &imx_pinctrl_pm_ops,
+               .pm = pm_sleep_ptr(&imx_pinctrl_pm_ops),
                .suppress_bind_attrs = true,
        },
        .probe = imx8mq_pinctrl_probe,