]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
staging: media: starfive: Remove links when unregistering devices
authorChanghuang Liang <changhuang.liang@starfivetech.com>
Mon, 11 Mar 2024 12:03:09 +0000 (05:03 -0700)
committerHans Verkuil <hverkuil-cisco@xs4all.nl>
Mon, 8 Apr 2024 11:48:19 +0000 (13:48 +0200)
Need to remove links when unregistering devices.

Fixes: ac7da4a73b10 ("media: staging: media: starfive: camss: Register devices")
Signed-off-by: Changhuang Liang <changhuang.liang@starfivetech.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
drivers/staging/media/starfive/camss/stf-camss.c

index f9613c2c9dfe9beb0df05e3aa94ac4b349556562..fecd3e67c7a1d58d94dfdf7d7a364d56f1c9a282 100644 (file)
@@ -162,6 +162,12 @@ err_isp_unregister:
 
 static void stfcamss_unregister_devs(struct stfcamss *stfcamss)
 {
+       struct stf_capture *cap_yuv = &stfcamss->captures[STF_CAPTURE_YUV];
+       struct stf_isp_dev *isp_dev = &stfcamss->isp_dev;
+
+       media_entity_remove_links(&isp_dev->subdev.entity);
+       media_entity_remove_links(&cap_yuv->video.vdev.entity);
+
        stf_isp_unregister(&stfcamss->isp_dev);
        stf_capture_unregister(stfcamss);
 }