nvdimm-btt: use bvec_kmap_local in btt_rw_integrity
authorChristoph Hellwig <hch@lst.de>
Thu, 20 May 2021 13:00:22 +0000 (15:00 +0200)
committerChristoph Hellwig <hch@lst.de>
Tue, 1 Mar 2022 12:19:58 +0000 (14:19 +0200)
Using local kmaps slightly reduces the chances to stray writes, and
the bvec interface cleans up the code a little bit.

Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/nvdimm/btt.c

index cbd994f7f1fe6563d63d2047c53c5c371594197e..9613e54c7a675bd7cb07f24612abf4143b423a34 100644 (file)
@@ -1163,17 +1163,15 @@ static int btt_rw_integrity(struct btt *btt, struct bio_integrity_payload *bip,
                 */
 
                cur_len = min(len, bv.bv_len);
-               mem = kmap_atomic(bv.bv_page);
+               mem = bvec_kmap_local(&bv);
                if (rw)
-                       ret = arena_write_bytes(arena, meta_nsoff,
-                                       mem + bv.bv_offset, cur_len,
+                       ret = arena_write_bytes(arena, meta_nsoff, mem, cur_len,
                                        NVDIMM_IO_ATOMIC);
                else
-                       ret = arena_read_bytes(arena, meta_nsoff,
-                                       mem + bv.bv_offset, cur_len,
+                       ret = arena_read_bytes(arena, meta_nsoff, mem, cur_len,
                                        NVDIMM_IO_ATOMIC);
 
-               kunmap_atomic(mem);
+               kunmap_local(mem);
                if (ret)
                        return ret;