IB/ipoib: Fix for notify send CQ failure messages

If IB_CQ_REPORT_MISSED_EVENTS flag is passed in ib_req_notify_cq()
it may return positive value indicating non-empty CQ.
If return code not verified the log might be flooded with false
warning messages "request notify on send CQ failed".

Fixes: 8966e28d2e40 ("IB/ipoib: Use NAPI in UD/TX flows")
Reviewed-by: Mike Marciniszyn <mike.marciniszyn@intel.com>
Signed-off-by: Alex Estrin <alex.estrin@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

diff --git a/drivers/infiniband/ulp/ipoib/ipoib_cm.c b/drivers/infiniband/ulp/ipoib/ipoib_cm.c
index d45b0f2aa987a21edfe258958899a51a933bb37e..dfbb8fdda5f6d736da91c11ab9125dd270dbaf32 100644 (file)
--- a/drivers/infiniband/ulp/ipoib/ipoib_cm.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_cm.c
@@ -766,12 +766,14 @@ void ipoib_cm_send(struct net_device *dev, struct sk_buff *skb, struct ipoib_cm_
        skb_orphan(skb);
        skb_dst_drop(skb);
 
-       if (netif_queue_stopped(dev))
-               if (ib_req_notify_cq(priv->send_cq, IB_CQ_NEXT_COMP |
-                                    IB_CQ_REPORT_MISSED_EVENTS)) {
+       if (netif_queue_stopped(dev)) {
+               rc = ib_req_notify_cq(priv->send_cq, IB_CQ_NEXT_COMP |
+                                     IB_CQ_REPORT_MISSED_EVENTS);
+               if (unlikely(rc < 0))
                        ipoib_warn(priv, "IPoIB/CM:request notify on send CQ failed\n");
+               else if (rc)
                        napi_schedule(&priv->send_napi);
-               }
+       }
 
        rc = post_send(priv, tx, tx->tx_head & (ipoib_sendq_size - 1), tx_req);
        if (unlikely(rc)) {

diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ib.c b/drivers/infiniband/ulp/ipoib/ipoib_ib.c
index a8760d40dfa61c1e17f58c3f14e73857a3f20d6f..10384ea50bed7a4ff78712efdcafc9fe0c93dcaf 100644 (file)
--- a/drivers/infiniband/ulp/ipoib/ipoib_ib.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_ib.c
@@ -644,7 +644,7 @@ int ipoib_send(struct net_device *dev, struct sk_buff *skb,
 
        if (netif_queue_stopped(dev))
                if (ib_req_notify_cq(priv->send_cq, IB_CQ_NEXT_COMP |
-                                    IB_CQ_REPORT_MISSED_EVENTS))
+                                    IB_CQ_REPORT_MISSED_EVENTS) < 0)
                        ipoib_warn(priv, "request notify on send CQ failed\n");
 
        rc = post_send(priv, priv->tx_head & (ipoib_sendq_size - 1),