staging: vchiq_arm: Use devm_kzalloc() for drv_mgmt allocation

The struct drv_mgmt 'mgmt' is currently allocated dynamically using
kzalloc(). Unfortunately, it is subjected to memory leaks in the error
handling paths of the probe() function.

To address this issue, use device resource management
helper devm_kzalloc(), to ensure cleanup after the allocation.

Cc: stable@vger.kernel.org
Fixes: 1c9e16b73166 ("staging: vc04_services: vchiq_arm: Split driver static and runtime data")
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/20241016130225.61024-3-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
index 0d8d5555e8af9b61d18a454f17de1845b9a67ca7..6c488b1e2624850d51fbc507965b66333521c86a 100644 (file)
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
@@ -1731,7 +1731,7 @@ static int vchiq_probe(struct platform_device *pdev)
                return -ENOENT;
        }
 
-       mgmt = kzalloc(sizeof(*mgmt), GFP_KERNEL);
+       mgmt = devm_kzalloc(&pdev->dev, sizeof(*mgmt), GFP_KERNEL);
        if (!mgmt)
                return -ENOMEM;
 
@@ -1789,8 +1789,6 @@ static void vchiq_remove(struct platform_device *pdev)
 
        arm_state = vchiq_platform_get_arm_state(&mgmt->state);
        kthread_stop(arm_state->ka_thread);
-
-       kfree(mgmt);
 }
 
 static struct platform_driver vchiq_driver = {