]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
iommu/vt-d: Downgrade warning for pre-enabled IR
authorLu Baolu <baolu.lu@linux.intel.com>
Tue, 2 Jul 2024 13:08:36 +0000 (21:08 +0800)
committerWill Deacon <will@kernel.org>
Wed, 3 Jul 2024 15:39:26 +0000 (16:39 +0100)
Emitting a warning is overkill in intel_setup_irq_remapping() since the
interrupt remapping is pre-enabled. For example, there's no guarantee
that kexec will explicitly disable interrupt remapping before booting a
new kernel. As a result, users are seeing warning messages like below
when they kexec boot a kernel, though there is nothing wrong:

 DMAR-IR: IRQ remapping was enabled on dmar18 but we are not in kdump mode
 DMAR-IR: IRQ remapping was enabled on dmar17 but we are not in kdump mode
 DMAR-IR: IRQ remapping was enabled on dmar16 but we are not in kdump mode
 ... ...

Downgrade the severity of this message to avoid user confusion.

CC: Paul Menzel <pmenzel@molgen.mpg.de>
Link: https://lore.kernel.org/linux-iommu/5517f76a-94ad-452c-bae6-34ecc0ec4831@molgen.mpg.de/
Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Link: https://lore.kernel.org/r/20240625043912.258036-1-baolu.lu@linux.intel.com
Link: https://lore.kernel.org/r/20240702130839.108139-5-baolu.lu@linux.intel.com
Signed-off-by: Will Deacon <will@kernel.org>
drivers/iommu/intel/irq_remapping.c

index e4a70886678cf1e6f5d42ef751583a49f322f013..e090ca07364bd4132e5f6d58c91ef1408a626585 100644 (file)
@@ -597,8 +597,8 @@ static int intel_setup_irq_remapping(struct intel_iommu *iommu)
 
        if (ir_pre_enabled(iommu)) {
                if (!is_kdump_kernel()) {
-                       pr_warn("IRQ remapping was enabled on %s but we are not in kdump mode\n",
-                               iommu->name);
+                       pr_info_once("IRQ remapping was enabled on %s but we are not in kdump mode\n",
+                                    iommu->name);
                        clear_ir_pre_enabled(iommu);
                        iommu_disable_irq_remapping(iommu);
                } else if (iommu_load_old_irte(iommu))