]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
iio: adc: ti-adc128s052: Use devm_mutex_init()
authorMatti Vaittinen <mazziesaccount@gmail.com>
Mon, 7 Apr 2025 11:36:23 +0000 (14:36 +0300)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Tue, 22 Apr 2025 18:10:03 +0000 (19:10 +0100)
Quoting Jonathan:
"Whilst it doesn't bring huge advantage, now we have devm_mutex_init()
it seems reasonable to use it and maybe catch a use after free for the
lock"

Switch to use devm_mutex_init() while working on this file.

Signed-off-by: Matti Vaittinen <mazziesaccount@gmail.com>
Link: https://patch.msgid.link/efe4a039e2bfbf4dcf30743f6b7b88fce3b9ee39.1744022065.git.mazziesaccount@gmail.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/adc/ti-adc128s052.c

index d0702d403fbec0ab565c3f14e7a4bbda5c875317..d90a5caa028f0f09101f1223b41b4cac33a3bf81 100644 (file)
@@ -172,7 +172,9 @@ static int adc128_probe(struct spi_device *spi)
        if (ret)
                return ret;
 
-       mutex_init(&adc->lock);
+       ret = devm_mutex_init(&spi->dev, &adc->lock);
+       if (ret)
+               return ret;
 
        return devm_iio_device_register(&spi->dev, indio_dev);
 }