]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
i40e: don't configure zero-size RSS table
authorMitch Williams <mitch.a.williams@intel.com>
Mon, 12 Sep 2016 21:18:43 +0000 (14:18 -0700)
committerDhaval Giani <dhaval.giani@oracle.com>
Wed, 8 Mar 2017 00:39:49 +0000 (19:39 -0500)
Orabug: 24568124

In some rare cases, we might get a VSI with no queues. In this case, we
cannot configure RSS on this VSI as it will try to divide by zero when
configuring the lookup table.

Change-ID: I6ae173a7dd3481a081e079eb10eb80275de2adb0
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
(cherry picked from commit a4fa59cc5bb028ebb8048e8dcb6f92b2a1ea07f6)
Signed-off-by: Brian Maly <brian.maly@oracle.com>
Signed-off-by: Dhaval Giani <dhaval.giani@oracle.com>
drivers/net/ethernet/intel/i40e/i40e_main.c

index cffe648f8bcbfbd91050c349cd270904faa53af1..9a4c767f7046bef1d2e8e0c03127e7dc296afdad 100644 (file)
@@ -8187,6 +8187,8 @@ static int i40e_pf_config_rss(struct i40e_pf *pf)
        if (!vsi->rss_size)
                vsi->rss_size = min_t(int, pf->alloc_rss_size,
                                      vsi->num_queue_pairs);
+       if (!vsi->rss_size)
+               return -EINVAL;
 
        lut = kzalloc(vsi->rss_table_size, GFP_KERNEL);
        if (!lut)