]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
x86/alternatives: Move text_poke_array completion from smp_text_poke_batch_finish...
authorIngo Molnar <mingo@kernel.org>
Fri, 11 Apr 2025 05:40:51 +0000 (07:40 +0200)
committerIngo Molnar <mingo@kernel.org>
Fri, 11 Apr 2025 09:01:34 +0000 (11:01 +0200)
Simplifies the code and improves code generation a bit:

   text    data     bss     dec     hex filename
  14769    1017    4112   19898    4dba alternative.o.before
  14742    1017    4112   19871    4d9f alternative.o.after

Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Juergen Gross <jgross@suse.com>
Cc: "H . Peter Anvin" <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: https://lore.kernel.org/r/20250411054105.2341982-40-mingo@kernel.org
arch/x86/kernel/alternative.c

index b47ad08535899ae4833496bbf7018b9becbb6cd6..556a82f576cd24b4d8f0632bbc2365ce0d016213 100644 (file)
@@ -2750,6 +2750,9 @@ static void smp_text_poke_batch_process(void)
                if (unlikely(!atomic_dec_and_test(refs)))
                        atomic_cond_read_acquire(refs, !VAL);
        }
+
+       /* They are all completed: */
+       text_poke_array.nr_entries = 0;
 }
 
 static void __smp_text_poke_batch_add(void *addr, const void *opcode, size_t len, const void *emulate)
@@ -2857,20 +2860,16 @@ static bool text_poke_addr_ordered(void *addr)
 
 void smp_text_poke_batch_finish(void)
 {
-       if (text_poke_array.nr_entries) {
+       if (text_poke_array.nr_entries)
                smp_text_poke_batch_process();
-               text_poke_array.nr_entries = 0;
-       }
 }
 
 static void smp_text_poke_batch_flush(void *addr)
 {
        lockdep_assert_held(&text_mutex);
 
-       if (text_poke_array.nr_entries == TP_ARRAY_NR_ENTRIES_MAX || !text_poke_addr_ordered(addr)) {
+       if (text_poke_array.nr_entries == TP_ARRAY_NR_ENTRIES_MAX || !text_poke_addr_ordered(addr))
                smp_text_poke_batch_process();
-               text_poke_array.nr_entries = 0;
-       }
 }
 
 /**