]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
mm/damon/core: simplify control flow in damon_register_ops()
authorTaotao Chen <chentaotao@didiglobal.com>
Thu, 20 Mar 2025 10:44:00 +0000 (18:44 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 1 Apr 2025 22:17:10 +0000 (15:17 -0700)
The function logic is not complex, so using goto is unnecessary.  Replace
it with a straightforward if-else to simplify control flow and improve
readability.

Link: https://lkml.kernel.org/r/Z9vxcPCw8tDsjKw1@OneApple
Signed-off-by: Taotao Chen <chentaotao@didiglobal.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/damon/core.c

index fc1eba3da419f5338dfd428ed971338048edc597..f0c1676f0599e0a2226565ab9853d490e433d69c 100644 (file)
@@ -76,14 +76,13 @@ int damon_register_ops(struct damon_operations *ops)
 
        if (ops->id >= NR_DAMON_OPS)
                return -EINVAL;
+
        mutex_lock(&damon_ops_lock);
        /* Fail for already registered ops */
-       if (__damon_is_registered_ops(ops->id)) {
+       if (__damon_is_registered_ops(ops->id))
                err = -EINVAL;
-               goto out;
-       }
-       damon_registered_ops[ops->id] = *ops;
-out:
+       else
+               damon_registered_ops[ops->id] = *ops;
        mutex_unlock(&damon_ops_lock);
        return err;
 }