]> www.infradead.org Git - users/hch/block.git/commitdiff
mmc: remove an extra blk_{get,put}_queue pair
authorChristoph Hellwig <hch@lst.de>
Tue, 15 Jun 2021 11:44:55 +0000 (13:44 +0200)
committerChristoph Hellwig <hch@lst.de>
Tue, 15 Jun 2021 11:45:53 +0000 (13:45 +0200)
The gendisk already acquires a reference to the queue when add_disk
is called, which dropped on put_disk.  So remove the superflous
extra refcounting.

Signed-off-by: Christoph Hellwig <hch@lst.de>
drivers/mmc/core/block.c

index 689eb9afeeed10868890cae049161de72d198f83..947624e76c33754fb683f5c9aff5a89fef835693 100644 (file)
@@ -201,7 +201,7 @@ static void mmc_blk_put(struct mmc_blk_data *md)
        md->usage--;
        if (md->usage == 0) {
                int devidx = mmc_get_devidx(md->disk);
-               blk_put_queue(md->queue.queue);
+
                ida_simple_remove(&mmc_blk_ida, devidx);
                put_disk(md->disk);
                kfree(md);
@@ -2326,18 +2326,6 @@ static struct mmc_blk_data *mmc_blk_alloc_req(struct mmc_card *card,
 
        md->queue.blkdata = md;
 
-       /*
-        * Keep an extra reference to the queue so that we can shutdown the
-        * queue (i.e. call blk_cleanup_queue()) while there are still
-        * references to the 'md'. The corresponding blk_put_queue() is in
-        * mmc_blk_put().
-        */
-       if (!blk_get_queue(md->queue.queue)) {
-               mmc_cleanup_queue(&md->queue);
-               ret = -ENODEV;
-               goto err_putdisk;
-       }
-
        md->disk->major = MMC_BLOCK_MAJOR;
        md->disk->first_minor = devidx * perdev_minors;
        md->disk->fops = &mmc_bdops;