]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
dmaengine: xilinx_dma: fix incompatible param warning in _child_probe()
authorShravya Kumbham <shravya.kumbham@xilinx.com>
Wed, 23 Dec 2020 11:21:01 +0000 (16:51 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 17 Jan 2021 13:04:22 +0000 (14:04 +0100)
commit faeb0731be0a31e2246b21a85fa7dabbd750101d upstream.

In xilinx_dma_child_probe function, the nr_channels variable is
passed to of_property_read_u32() which expects an u32 return value
pointer. Modify the nr_channels variable type from int to u32 to
fix the incompatible parameter coverity warning.

Addresses-Coverity: Event incompatible_param.
Fixes: 1a9e7a03c761 ("dmaengine: vdma: Add support for mulit-channel dma mode")
Signed-off-by: Shravya Kumbham <shravya.kumbham@xilinx.com>
Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xilinx.com>
Link: https://lore.kernel.org/r/1608722462-29519-3-git-send-email-radhey.shyam.pandey@xilinx.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/dma/xilinx/xilinx_dma.c

index 2245ff18e34e15aa0c4f71abf5b0bb1560d12062..fa261fff7655b291c5e0f01ca24d584e9c67420d 100644 (file)
@@ -2529,7 +2529,8 @@ static int xilinx_dma_chan_probe(struct xilinx_dma_device *xdev,
 static int xilinx_dma_child_probe(struct xilinx_dma_device *xdev,
                                    struct device_node *node)
 {
-       int ret, i, nr_channels = 1;
+       int ret, i;
+       u32 nr_channels = 1;
 
        ret = of_property_read_u32(node, "dma-channels", &nr_channels);
        if ((ret < 0) && xdev->mcdma)