]> www.infradead.org Git - users/hch/misc.git/commitdiff
perf annotate: Factor out annotate_browser__show_function_title()
authorNamhyung Kim <namhyung@kernel.org>
Mon, 8 Sep 2025 06:10:49 +0000 (23:10 -0700)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Tue, 9 Sep 2025 18:12:15 +0000 (15:12 -0300)
It'll be used in other places.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Ian Rogers <irogers@google.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/ui/browsers/annotate.c

index 6fd4c3483c5068ae1f2ae0ec485cd364e55adbba..39f042837d4385592407ce35a36691a0ec18bcf5 100644 (file)
@@ -555,6 +555,20 @@ static int sym_title(struct symbol *sym, struct map *map, char *title,
                        annotate_opts.code_with_type ? "[Type]" : "");
 }
 
+static void annotate_browser__show_function_title(struct annotate_browser *browser)
+{
+       struct ui_browser *b = &browser->b;
+       struct map_symbol *ms = b->priv;
+       struct symbol *sym = ms->sym;
+       char title[SYM_TITLE_MAX_SIZE];
+
+       sym_title(sym, ms->map, title, sizeof(title), annotate_opts.percent_type);
+
+       ui_browser__gotorc_title(b, 0, 0);
+       ui_browser__set_color(b, HE_COLORSET_ROOT);
+       ui_browser__write_nstring(b, title, b->width + 1);
+}
+
 /*
  * This can be called from external jumps, i.e. jumps from one function
  * to another, like from the kernel's entry_SYSCALL_64 function to the
@@ -768,19 +782,10 @@ bool annotate_browser__continue_search_reverse(struct annotate_browser *browser,
 
 static int annotate_browser__show(struct annotate_browser *browser, char *title, const char *help)
 {
-       struct ui_browser *b = &browser->b;
-       struct map_symbol *ms = b->priv;
-       struct symbol *sym = ms->sym;
-       char symbol_dso[SYM_TITLE_MAX_SIZE];
-
-       if (ui_browser__show(b, title, help) < 0)
+       if (ui_browser__show(&browser->b, title, help) < 0)
                return -1;
 
-       sym_title(sym, ms->map, symbol_dso, sizeof(symbol_dso), annotate_opts.percent_type);
-
-       ui_browser__gotorc_title(b, 0, 0);
-       ui_browser__set_color(b, HE_COLORSET_ROOT);
-       ui_browser__write_nstring(b, symbol_dso, b->width + 1);
+       annotate_browser__show_function_title(browser);
        return 0;
 }