mm/mprotect: minor can_change_pte_writable() cleanups

We want to replicate this code for handling PMDs soon.

(1) No need to crash the kernel, warning and rejecting is good enough. As
    this will no longer get optimized out, drop the pte_write() check: no
    harm would be done.

(2) Add a comment why PROT_NONE mapped pages are excluded.

(3) Add a comment regarding MAP_SHARED handling and why we rely on the
    dirty bit in the PTE.

Link: https://lkml.kernel.org/r/20221108174652.198904-3-david@redhat.com
Signed-off-by: David Hildenbrand <david@redhat.com>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Cc: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: Dave Chinner <david@fromorbit.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Mike Rapoport <rppt@kernel.org>
Cc: Nadav Amit <namit@vmware.com>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Peter Xu <peterx@redhat.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/mm/mprotect.c b/mm/mprotect.c
index 86a28c0e190fe43d093a27aeaaebf338197b8b17..72aabffb787130151346fab0b4c78bd2ff544979 100644 (file)
--- a/mm/mprotect.c
+++ b/mm/mprotect.c
@@ -44,8 +44,10 @@ static inline bool can_change_pte_writable(struct vm_area_struct *vma,
 {
        struct page *page;
 
-       VM_BUG_ON(!(vma->vm_flags & VM_WRITE) || pte_write(pte));
+       if (WARN_ON_ONCE(!(vma->vm_flags & VM_WRITE)))
+               return false;
 
+       /* Don't touch entries that are not even readable. */
        if (pte_protnone(pte))
                return false;
 
@@ -59,15 +61,22 @@ static inline bool can_change_pte_writable(struct vm_area_struct *vma,
 
        if (!(vma->vm_flags & VM_SHARED)) {
                /*
-                * We can only special-case on exclusive anonymous pages,
-                * because we know that our write-fault handler similarly would
-                * map them writable without any additional checks while holding
-                * the PT lock.
+                * Writable MAP_PRIVATE mapping: We can only special-case on
+                * exclusive anonymous pages, because we know that our
+                * write-fault handler similarly would map them writable without
+                * any additional checks while holding the PT lock.
                 */
                page = vm_normal_page(vma, addr, pte);
                return page && PageAnon(page) && PageAnonExclusive(page);
        }
 
+       /*
+        * Writable MAP_SHARED mapping: "clean" might indicate that the FS still
+        * needs a real write-fault for writenotify
+        * (see vma_wants_writenotify()). If "dirty", the assumption is that the
+        * FS was already notified and we can simply mark the PTE writable
+        * just like the write-fault handler would do.
+        */
        return pte_dirty(pte);
 }