iio: light: opt4060: Switch to sparse friendly iio_device_claim/release_direct()

These new functions allow sparse to find failures to release
direct mode reducing chances of bugs over the claim_direct_mode()
functions that are deprecated.  This is a case where the code
is pinning down the mode so also has a claim on buffered mode.
A follow up set may move those calls over to a sparse friendly
form as well.

Tested-by: Per-Daniel Olsson <perdaniel.olsson@axis.com>
Reviewed-by: Per-Daniel Olsson <perdaniel.olsson@axis.com>
Reviewed-by: David Lechner <dlechner@baylibre.com>
Link: https://patch.msgid.link/20250309170633.1347476-10-jic23@kernel.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

diff --git a/drivers/iio/light/opt4060.c b/drivers/iio/light/opt4060.c
index ab55f8d2ea0cfb6b3a890cdf53932a17591070f9..f4085020e03ebadb2b91db3212449db82d738ebd 100644 (file)
--- a/drivers/iio/light/opt4060.c
+++ b/drivers/iio/light/opt4060.c
@@ -311,7 +311,7 @@ any_mode_retry:
                 * concurrently change. And we just keep trying until we get one
                 * of the modes...
                 */
-               if (iio_device_claim_direct_mode(indio_dev))
+               if (!iio_device_claim_direct(indio_dev))
                        goto any_mode_retry;
                /*
                 * This path means that we managed to claim direct mode. In
@@ -320,7 +320,8 @@ any_mode_retry:
                 */
                ret = opt4060_set_state_common(chip, continuous_sampling,
                                               continuous_irq);
-               iio_device_release_direct_mode(indio_dev);
+               iio_device_release_direct(indio_dev);
+               return ret;
        } else {
                /*
                 * This path means that we managed to claim buffer mode. In