]> www.infradead.org Git - users/hch/misc.git/commitdiff
kprobes: Use RCU in all users of __module_text_address().
authorSebastian Andrzej Siewior <bigeasy@linutronix.de>
Wed, 29 Jan 2025 08:49:25 +0000 (09:49 +0100)
committerPetr Pavlu <petr.pavlu@suse.com>
Mon, 10 Mar 2025 10:54:46 +0000 (11:54 +0100)
__module_text_address() can be invoked within a RCU section, there is no
requirement to have preemption disabled.

Replace the preempt_disable() section around __module_text_address()
with RCU.

Cc: David S. Miller <davem@davemloft.net>
Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Naveen N Rao <naveen@kernel.org>
Cc: linux-trace-kernel@vger.kernel.org
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/20250129084925.9ppBjGLC@linutronix.de
Signed-off-by: Petr Pavlu <petr.pavlu@suse.com>
kernel/kprobes.c

index 88aeac84e4c057261da25124b81abf177ed51d23..ffe0c3d52306377a1a1cfd7e0765df7ec0d4f3e5 100644 (file)
@@ -1547,7 +1547,7 @@ static int check_kprobe_address_safe(struct kprobe *p,
        /* Ensure the address is in a text area, and find a module if exists. */
        *probed_mod = NULL;
        if (!core_kernel_text((unsigned long) p->addr)) {
-               guard(preempt)();
+               guard(rcu)();
                *probed_mod = __module_text_address((unsigned long) p->addr);
                if (!(*probed_mod))
                        return -EINVAL;