]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
arm64: dts: qcom: msm8916: Replace invalid bias-pull-none property
authorStephan Gerhold <stephan@gerhold.net>
Fri, 5 Jun 2020 18:59:14 +0000 (20:59 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 21 Aug 2020 07:48:03 +0000 (09:48 +0200)
[ Upstream commit 1b6a1a162defe649c5599d661b58ac64bb6f31b6 ]

msm8916-pins.dtsi specifies "bias-pull-none" for most of the audio
pin configurations. This was likely copied from the qcom kernel fork
where the same property was used for these audio pins.

However, "bias-pull-none" actually does not exist at all - not in
mainline and not in downstream. I can only guess that the original
intention was to configure "no pull", i.e. bias-disable.

Change it to that instead.

Fixes: 143bb9ad85b7 ("arm64: dts: qcom: add audio pinctrls")
Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Link: https://lore.kernel.org/r/20200605185916.318494-2-stephan@gerhold.net
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
arch/arm64/boot/dts/qcom/msm8916-pins.dtsi

index 4cb0b5834143266aee9228486ee9bb6d61cb4167..69ba1d79bcd5d59b8c6bcbba3858d7a70ff8d57f 100644 (file)
                                pins = "gpio63", "gpio64", "gpio65", "gpio66",
                                       "gpio67", "gpio68";
                                drive-strength = <8>;
-                               bias-pull-none;
+                               bias-disable;
                        };
                };
                cdc_pdm_lines_sus: pdm_lines_off {
                                pins = "gpio113", "gpio114", "gpio115",
                                       "gpio116";
                                drive-strength = <8>;
-                               bias-pull-none;
+                               bias-disable;
                        };
                };
 
                        pinconf {
                                pins = "gpio110";
                                drive-strength = <8>;
-                               bias-pull-none;
+                               bias-disable;
                        };
                };
 
                        pinconf {
                                pins = "gpio116";
                                drive-strength = <8>;
-                               bias-pull-none;
+                               bias-disable;
                        };
                };
                ext_mclk_tlmm_lines_sus: mclk_lines_off {
                                pins = "gpio112", "gpio117", "gpio118",
                                        "gpio119";
                                drive-strength = <8>;
-                               bias-pull-none;
+                               bias-disable;
                        };
                };
                ext_sec_tlmm_lines_sus: tlmm_lines_off {