ieee802154: no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Alexander Aring <alex.aring@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Harry Morris <h.morris@cascoda.com>
Cc: linux-wpan@vger.kernel.org
Cc: netdev@vger.kernel.org
Acked-by: Stefan Schmidt <stefan@datenfreihafen.org>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ieee802154/adf7242.c b/drivers/net/ieee802154/adf7242.c
index c9392d70e639dfdef3f20f1afd693dc0c8d760e5..5a37514e423477cee4a4de4ccda29937a25e688b 100644 (file)
--- a/drivers/net/ieee802154/adf7242.c
+++ b/drivers/net/ieee802154/adf7242.c
@@ -1158,23 +1158,16 @@ static int adf7242_stats_show(struct seq_file *file, void *offset)
        return 0;
 }
 
-static int adf7242_debugfs_init(struct adf7242_local *lp)
+static void adf7242_debugfs_init(struct adf7242_local *lp)
 {
        char debugfs_dir_name[DNAME_INLINE_LEN + 1] = "adf7242-";
-       struct dentry *stats;
 
        strncat(debugfs_dir_name, dev_name(&lp->spi->dev), DNAME_INLINE_LEN);
 
        lp->debugfs_root = debugfs_create_dir(debugfs_dir_name, NULL);
-       if (IS_ERR_OR_NULL(lp->debugfs_root))
-               return PTR_ERR_OR_ZERO(lp->debugfs_root);
 
-       stats = debugfs_create_devm_seqfile(&lp->spi->dev, "status",
-                                           lp->debugfs_root,
-                                           adf7242_stats_show);
-       return PTR_ERR_OR_ZERO(stats);
-
-       return 0;
+       debugfs_create_devm_seqfile(&lp->spi->dev, "status", lp->debugfs_root,
+                                   adf7242_stats_show);
 }
 
 static const s32 adf7242_powers[] = {

diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c
index 595cf7e2a65158a18b864ebe1e562949a30010db..7d67f41387f5577959839f902128b1777b4b51ee 100644 (file)
--- a/drivers/net/ieee802154/at86rf230.c
+++ b/drivers/net/ieee802154/at86rf230.c
@@ -1626,24 +1626,16 @@ static int at86rf230_stats_show(struct seq_file *file, void *offset)
 }
 DEFINE_SHOW_ATTRIBUTE(at86rf230_stats);
 
-static int at86rf230_debugfs_init(struct at86rf230_local *lp)
+static void at86rf230_debugfs_init(struct at86rf230_local *lp)
 {
        char debugfs_dir_name[DNAME_INLINE_LEN + 1] = "at86rf230-";
-       struct dentry *stats;
 
        strncat(debugfs_dir_name, dev_name(&lp->spi->dev), DNAME_INLINE_LEN);
 
        at86rf230_debugfs_root = debugfs_create_dir(debugfs_dir_name, NULL);
-       if (!at86rf230_debugfs_root)
-               return -ENOMEM;
-
-       stats = debugfs_create_file("trac_stats", 0444,
-                                   at86rf230_debugfs_root, lp,
-                                   &at86rf230_stats_fops);
-       if (!stats)
-               return -ENOMEM;
 
-       return 0;
+       debugfs_create_file("trac_stats", 0444, at86rf230_debugfs_root, lp,
+                           &at86rf230_stats_fops);
 }
 
 static void at86rf230_debugfs_remove(void)
@@ -1651,7 +1643,7 @@ static void at86rf230_debugfs_remove(void)
        debugfs_remove_recursive(at86rf230_debugfs_root);
 }
 #else
-static int at86rf230_debugfs_init(struct at86rf230_local *lp) { return 0; }
+static void at86rf230_debugfs_init(struct at86rf230_local *lp) { }
 static void at86rf230_debugfs_remove(void) { }
 #endif
 
@@ -1751,9 +1743,7 @@ static int at86rf230_probe(struct spi_device *spi)
        /* going into sleep by default */
        at86rf230_sleep(lp);
 
-       rc = at86rf230_debugfs_init(lp);
-       if (rc)
-               goto free_dev;
+       at86rf230_debugfs_init(lp);
 
        rc = ieee802154_register_hw(lp->hw);
        if (rc)

diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c
index b188fce3f6410edf3e3a2d3f375c86cfe1b84bba..11402dc347db33b66ba45e1ffb60aedaf48c6ae5 100644 (file)
--- a/drivers/net/ieee802154/ca8210.c
+++ b/drivers/net/ieee802154/ca8210.c
@@ -3019,14 +3019,7 @@ static int ca8210_test_interface_init(struct ca8210_priv *priv)
                priv,
                &test_int_fops
        );
-       if (IS_ERR(test->ca8210_dfs_spi_int)) {
-               dev_err(
-                       &priv->spi->dev,
-                       "Error %ld when creating debugfs node\n",
-                       PTR_ERR(test->ca8210_dfs_spi_int)
-               );
-               return PTR_ERR(test->ca8210_dfs_spi_int);
-       }
+
        debugfs_create_symlink("ca8210", NULL, node_name);
        init_waitqueue_head(&test->readq);
        return kfifo_alloc(