test_firmware: use str_true_false() helper

Replace ternary (condition ?  "true" : "false") expressions with the
str_true_false() helper from string_choices.h.  This improves readability
by replacing the three-operand ternary with a single function call,
ensures consistent string output, and allows potential string
deduplication by the linker, resulting in a slightly smaller binary.

Link: https://lkml.kernel.org/r/20250814095033.244034-1-visitorckw@gmail.com
Signed-off-by: Kuan-Wei Chiu <visitorckw@gmail.com>
Cc: Kuan-Wei Chiu <visitorckw@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/lib/test_firmware.c b/lib/test_firmware.c
index 211222e63328f970228920f5662ee80cc7f51215..be4f93124901e5faac41f48a66dabe6da56be0ca 100644 (file)
--- a/lib/test_firmware.c
+++ b/lib/test_firmware.c
@@ -26,6 +26,7 @@
 #include <linux/kthread.h>
 #include <linux/vmalloc.h>
 #include <linux/efi_embedded_fw.h>
+#include <linux/string_choices.h>
 
 MODULE_IMPORT_NS("TEST_FIRMWARE");
 
@@ -304,17 +305,17 @@ static ssize_t config_show(struct device *dev,
                        "FW_ACTION_NOUEVENT");
        len += scnprintf(buf + len, PAGE_SIZE - len,
                        "into_buf:\t\t%s\n",
-                       test_fw_config->into_buf ? "true" : "false");
+                       str_true_false(test_fw_config->into_buf));
        len += scnprintf(buf + len, PAGE_SIZE - len,
                        "buf_size:\t%zu\n", test_fw_config->buf_size);
        len += scnprintf(buf + len, PAGE_SIZE - len,
                        "file_offset:\t%zu\n", test_fw_config->file_offset);
        len += scnprintf(buf + len, PAGE_SIZE - len,
                        "partial:\t\t%s\n",
-                       test_fw_config->partial ? "true" : "false");
+                       str_true_false(test_fw_config->partial));
        len += scnprintf(buf + len, PAGE_SIZE - len,
                        "sync_direct:\t\t%s\n",
-                       test_fw_config->sync_direct ? "true" : "false");
+                       str_true_false(test_fw_config->sync_direct));
        len += scnprintf(buf + len, PAGE_SIZE - len,
                        "read_fw_idx:\t%u\n", test_fw_config->read_fw_idx);
        if (test_fw_config->upload_name)