]> www.infradead.org Git - nvme.git/commitdiff
bcachefs: Fix bch2_have_enough_devs() for BCH_SB_MEMBER_INVALID
authorKent Overstreet <kent.overstreet@linux.dev>
Sat, 12 Oct 2024 02:00:44 +0000 (22:00 -0400)
committerKent Overstreet <kent.overstreet@linux.dev>
Sat, 12 Oct 2024 02:20:51 +0000 (22:20 -0400)
This fixes a kasan splat in the ec device removal tests.

Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
fs/bcachefs/replicas.c

index 797da103231897532a73993cca3b41549a94ddd2..477ef0997949bf6dab11f739d0d547db92b6d3fb 100644 (file)
@@ -821,6 +821,11 @@ bool bch2_have_enough_devs(struct bch_fs *c, struct bch_devs_mask devs,
 
                rcu_read_lock();
                for (unsigned i = 0; i < e->nr_devs; i++) {
+                       if (e->devs[i] == BCH_SB_MEMBER_INVALID) {
+                               nr_failed++;
+                               continue;
+                       }
+
                        nr_online += test_bit(e->devs[i], devs.d);
 
                        struct bch_dev *ca = bch2_dev_rcu_noerror(c, e->devs[i]);