]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
dmaengine: at_hdmac: add missing kfree() call in at_dma_xlate()
authorYu Kuai <yukuai3@huawei.com>
Mon, 17 Aug 2020 11:57:28 +0000 (19:57 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 9 Jan 2021 12:43:47 +0000 (13:43 +0100)
commit e097eb7473d9e70da9e03276f61cd392ccb9d79f upstream.

If memory allocation for 'atslave' succeed, at_dma_xlate() doesn't have a
corresponding kfree() in exception handling. Thus add kfree() for this
function implementation.

Fixes: bbe89c8e3d59 ("at_hdmac: move to generic DMA binding")
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Link: https://lore.kernel.org/r/20200817115728.1706719-4-yukuai3@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/dma/at_hdmac.c

index 05f4838a23d55ca6275b8801f7f8dc05c7a9dba1..c52718b37f8fd2c19a3507ce47ec5f646f75d359 100644 (file)
@@ -1718,6 +1718,7 @@ static struct dma_chan *at_dma_xlate(struct of_phandle_args *dma_spec,
        chan = dma_request_channel(mask, at_dma_filter, atslave);
        if (!chan) {
                put_device(&dmac_pdev->dev);
+               kfree(atslave);
                return NULL;
        }