iio: dac: lpc18xx_dac: Make use of the helper function dev_err_probe()

When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.

Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Link: https://lore.kernel.org/r/20210928013902.1341-2-caihuoqing@baidu.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

diff --git a/drivers/iio/dac/lpc18xx_dac.c b/drivers/iio/dac/lpc18xx_dac.c
index 9e38607a189eda2f05ab41e06e362ba90c062d5a..5502e4f62f0d6ae71fc45431c188c0e23710578a 100644 (file)
--- a/drivers/iio/dac/lpc18xx_dac.c
+++ b/drivers/iio/dac/lpc18xx_dac.c
@@ -121,16 +121,14 @@ static int lpc18xx_dac_probe(struct platform_device *pdev)
                return PTR_ERR(dac->base);
 
        dac->clk = devm_clk_get(&pdev->dev, NULL);
-       if (IS_ERR(dac->clk)) {
-               dev_err(&pdev->dev, "error getting clock\n");
-               return PTR_ERR(dac->clk);
-       }
+       if (IS_ERR(dac->clk))
+               return dev_err_probe(&pdev->dev, PTR_ERR(dac->clk),
+                                    "error getting clock\n");
 
        dac->vref = devm_regulator_get(&pdev->dev, "vref");
-       if (IS_ERR(dac->vref)) {
-               dev_err(&pdev->dev, "error getting regulator\n");
-               return PTR_ERR(dac->vref);
-       }
+       if (IS_ERR(dac->vref))
+               return dev_err_probe(&pdev->dev, PTR_ERR(dac->vref),
+                                    "error getting regulator\n");
 
        indio_dev->name = dev_name(&pdev->dev);
        indio_dev->info = &lpc18xx_dac_info;