]> www.infradead.org Git - linux.git/commitdiff
gpio: pca953x: log an error when failing to get the reset GPIO
authorLuca Ceresoli <luca.ceresoli@bootlin.com>
Thu, 19 Dec 2024 09:39:46 +0000 (10:39 +0100)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Fri, 20 Dec 2024 13:42:40 +0000 (14:42 +0100)
When the dirver fails getting this GPIO, it fails silently. Log an error
message to make debugging a lot easier by just reading dmesg.

Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Fixes: 054ccdef8b28 ("gpio: pca953x: Add optional reset gpio control")
Link: https://lore.kernel.org/r/20241219-pca953x-log-no-reset-gpio-v1-1-9aa7bcc45ead@bootlin.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpio-pca953x.c

index 272febc3230e90baf370811f498383b9fb12cc6f..be4c9981ebc404ad5c1e1b0ba9f9f948122de462 100644 (file)
@@ -1088,7 +1088,8 @@ static int pca953x_probe(struct i2c_client *client)
                 */
                reset_gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_LOW);
                if (IS_ERR(reset_gpio))
-                       return PTR_ERR(reset_gpio);
+                       return dev_err_probe(dev, PTR_ERR(reset_gpio),
+                                            "Failed to get reset gpio\n");
        }
 
        chip->client = client;