scsi: arcmsr: arcmsr_hba: Remove statement with no effect

According to LKP, commit 18bc435e0a1d ("scsi: arcmsr: Remove some set but
unused variables") can be furthered to remove the entire statement and not
just the unused variable read into.

Snipped LKP report:

 config: x86_64-randconfig-m001-20200719
 compiler: gcc-9 (Debian 9.3.0-14) 9.3.0

 New smatch warnings:
  drivers/scsi/arcmsr/arcmsr_hba.c:1490 arcmsr_done4abort_postqueue() warn: statement has no effect 8
  drivers/scsi/arcmsr/arcmsr_hba.c:2459 arcmsr_hbaD_postqueue_isr() warn: statement has no effect 8
  drivers/scsi/arcmsr/arcmsr_hba.c:3526 arcmsr_hbaD_polling_ccbdone() warn: statement has no effect 8

 1a4f550a09f89e Nick Cheng  2007-09-13  1401  static void arcmsr_done4abort_postqueue(struct AdapterControlBlock *acb)
 1a4f550a09f89e Nick Cheng  2007-09-13  1402  {
 [...]
 18bc435e0a1de2 Lee Jones   2020-07-13 @1490                             pmu->done_qbuffer[doneq_index & 0xFFF].addressHigh;
                                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 Delete this line.
 [...]

Link: https://lore.kernel.org/r/20200721164148.2617584-2-lee.jones@linaro.org
Cc: support@areca.com.tw
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

diff --git a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c
index 1c252934409c72555a93bcaaa850b13851b6789e..fa562a085600ded315af1e20442e2372ff4d31e6 100644 (file)
--- a/drivers/scsi/arcmsr/arcmsr_hba.c
+++ b/drivers/scsi/arcmsr/arcmsr_hba.c
@@ -1487,7 +1487,6 @@ static void arcmsr_done4abort_postqueue(struct AdapterControlBlock *acb)
                                        ((toggle ^ 0x4000) + 1);
                                doneq_index = pmu->doneq_index;
                                spin_unlock_irqrestore(&acb->doneq_lock, flags);
-                               pmu->done_qbuffer[doneq_index & 0xFFF].addressHigh;
                                addressLow = pmu->done_qbuffer[doneq_index &
                                        0xFFF].addressLow;
                                ccb_cdb_phy = (addressLow & 0xFFFFFFF0);
@@ -2456,7 +2455,6 @@ static void arcmsr_hbaD_postqueue_isr(struct AdapterControlBlock *acb)
                        pmu->doneq_index = index_stripped ? (index_stripped | toggle) :
                                ((toggle ^ 0x4000) + 1);
                        doneq_index = pmu->doneq_index;
-                       pmu->done_qbuffer[doneq_index & 0xFFF].addressHigh;
                        addressLow = pmu->done_qbuffer[doneq_index &
                                0xFFF].addressLow;
                        ccb_cdb_phy = (addressLow & 0xFFFFFFF0);
@@ -3523,7 +3521,6 @@ polling_hbaD_ccb_retry:
                                ((toggle ^ 0x4000) + 1);
                doneq_index = pmu->doneq_index;
                spin_unlock_irqrestore(&acb->doneq_lock, flags);
-               pmu->done_qbuffer[doneq_index & 0xFFF].addressHigh;
                flag_ccb = pmu->done_qbuffer[doneq_index & 0xFFF].addressLow;
                ccb_cdb_phy = (flag_ccb & 0xFFFFFFF0);
                if (acb->cdb_phyadd_hipart)