]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
net/mlx5e: Remove redundant check in CQE recovery flow of tx reporter
authorAya Levin <ayal@mellanox.com>
Thu, 8 Aug 2019 12:55:48 +0000 (15:55 +0300)
committerSasha Levin <sashal@kernel.org>
Sun, 25 Aug 2019 14:10:38 +0000 (10:10 -0400)
[ Upstream commit a4e508cab623951dc4754f346e5673714f3bbade ]

Remove check of recovery bit, in the beginning of the CQE recovery
function. This test is already performed right before the reporter
is invoked, when CQE error is detected.

Fixes: de8650a82071 ("net/mlx5e: Add tx reporter support")
Signed-off-by: Aya Levin <ayal@mellanox.com>
Signed-off-by: Saeed Mahameed <saeedm@mellanox.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/mellanox/mlx5/core/en/reporter_tx.c

index b307234b4e05bd1ea0610b74558b9fcb6219473a..c1caf14bc334632bdf7a2c67d067665f612c9536 100644 (file)
@@ -76,9 +76,6 @@ static int mlx5e_tx_reporter_err_cqe_recover(struct mlx5e_txqsq *sq)
        u8 state;
        int err;
 
-       if (!test_bit(MLX5E_SQ_STATE_RECOVERING, &sq->state))
-               return 0;
-
        err = mlx5_core_query_sq_state(mdev, sq->sqn, &state);
        if (err) {
                netdev_err(dev, "Failed to query SQ 0x%x state. err = %d\n",