USB: gadget: ci13xxx: fix complete() callback for no_interrupt rq's

CI13xxx UDC driver doesn't call complete() callback for requests
with flag no_interrupt set. Thus gadget drivers (like g_ether) are
never notifed about successfully (or not) transmitted requests. As
a result in case of g_ether and queued request with no_interrupt=1
fields g_ether is never notifed about sent packets and TX stalls.

Solution: treat no_interrupt flag like all other UDC drivers do and
call complete() callback for all requests.

Signed-off-by: Artem Leonenko <tikkeri@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

diff --git a/drivers/usb/gadget/ci13xxx_udc.c b/drivers/usb/gadget/ci13xxx_udc.c
index f20e861deebfd7ea4e08b62f2f6ddb37bff49c63..0060eef0e923b171a231a6323e83f364bfc99087 100644 (file)
--- a/drivers/usb/gadget/ci13xxx_udc.c
+++ b/drivers/usb/gadget/ci13xxx_udc.c
@@ -1551,7 +1551,7 @@ __acquires(mEp->lock)
                list_del_init(&mReq->queue);
                mReq->req.status = -ESHUTDOWN;
 
-               if (!mReq->req.no_interrupt && mReq->req.complete != NULL) {
+               if (mReq->req.complete != NULL) {
                        spin_unlock(mEp->lock);
                        mReq->req.complete(&mEp->ep, &mReq->req);
                        spin_lock(mEp->lock);
@@ -1802,7 +1802,7 @@ __acquires(mEp->lock)
                _hardware_enqueue(mEp, mReqEnq);
        }
 
-       if (!mReq->req.no_interrupt && mReq->req.complete != NULL) {
+       if (mReq->req.complete != NULL) {
                spin_unlock(mEp->lock);
                mReq->req.complete(&mEp->ep, &mReq->req);
                spin_lock(mEp->lock);
@@ -2213,7 +2213,7 @@ static int ep_dequeue(struct usb_ep *ep, struct usb_request *req)
        list_del_init(&mReq->queue);
        req->status = -ECONNRESET;
 
-       if (!mReq->req.no_interrupt && mReq->req.complete != NULL) {
+       if (mReq->req.complete != NULL) {
                spin_unlock(mEp->lock);
                mReq->req.complete(&mEp->ep, &mReq->req);
                spin_lock(mEp->lock);