can: grcan: move napi_enable() from under spin lock

I don't see any reason why napi_enable() needs to be under the lock,
only reason I could think of is if the IRQ also took this lock
but it doesn't. napi_enable() will soon need to sleep.

Acked-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Reviewed-by: Francois Romieu <romieu@fr.zoreil.com>
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
Link: https://patch.msgid.link/20250111024742.3680902-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/drivers/net/can/grcan.c b/drivers/net/can/grcan.c
index cdf0ec9fa7f3c2102f776be3422fdb779df9fe7b..21a61b86f67df7c99c51820e5a018bce774f866c 100644 (file)
--- a/drivers/net/can/grcan.c
+++ b/drivers/net/can/grcan.c
@@ -1073,9 +1073,10 @@ static int grcan_open(struct net_device *dev)
        if (err)
                goto exit_close_candev;
 
+       napi_enable(&priv->napi);
+
        spin_lock_irqsave(&priv->lock, flags);
 
-       napi_enable(&priv->napi);
        grcan_start(dev);
        if (!(priv->can.ctrlmode & CAN_CTRLMODE_LISTENONLY))
                netif_start_queue(dev);