When possible use dev_err_probe help to properly deal with the
PROBE_DEFER error, the benefit is that DEFER issue will be logged
in the devices_deferred debugfs file.
Using dev_err_probe() can reduce code size, and the error value
gets printed.
Signed-off-by: Cai Huoqing <caihuoqing@baidu.com>
Reviewed-by: Marcus Folkesson <marcus.folkesson@gmail.com>
Link: https://lore.kernel.org/r/20210928013902.1341-3-caihuoqing@baidu.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
 
        }
 
        priv->vref_reg = devm_regulator_get(&spi->dev, "vref");
-       if (IS_ERR(priv->vref_reg)) {
-               dev_err(&spi->dev, "vref regulator not specified\n");
-               return PTR_ERR(priv->vref_reg);
-       }
+       if (IS_ERR(priv->vref_reg))
+               return dev_err_probe(&spi->dev, PTR_ERR(priv->vref_reg),
+                                    "vref regulator not specified\n");
 
        ret = regulator_enable(priv->vref_reg);
        if (ret) {