]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
cifs: fix unitialized variable poential problem with network I/O cache lock patch
authorSteve French <stfrench@microsoft.com>
Thu, 16 Jan 2020 21:58:00 +0000 (15:58 -0600)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Feb 2020 07:38:43 +0000 (08:38 +0100)
[ Upstream commit 463a7b457c02250a84faa1d23c52da9e3364aed2 ]

static analysis with Coverity detected an issue with the following
commit:

 Author: Paulo Alcantara (SUSE) <pc@cjr.nz>
 Date:   Wed Dec 4 17:38:03 2019 -0300

    cifs: Avoid doing network I/O while holding cache lock

Addresses-Coverity: ("Uninitialized pointer read")
Reported-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/cifs/dfs_cache.c

index 2faa05860a4830ef76d3ac75a8e1bc828fdc9747..cf6cec59696c2354ffe51afaf1d1c5af3b0bce36 100644 (file)
@@ -1319,7 +1319,7 @@ static struct cifs_ses *find_root_ses(struct dfs_cache_vol_info *vi,
        char *mdata = NULL, *devname = NULL;
        struct TCP_Server_Info *server;
        struct cifs_ses *ses;
-       struct smb_vol vol;
+       struct smb_vol vol = {NULL};
 
        rpath = get_dfs_root(path);
        if (IS_ERR(rpath))