]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
media: cxusb-analog: fix V4L2 dependency
authorArnd Bergmann <arnd@arndb.de>
Thu, 7 May 2020 21:33:14 +0000 (23:33 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Aug 2020 06:16:07 +0000 (08:16 +0200)
[ Upstream commit 1a55caf010c46d4f2073f9e92e97ef65358c16bf ]

CONFIG_DVB_USB_CXUSB_ANALOG is a 'bool' symbol with a dependency on the
tristate CONFIG_VIDEO_V4L2, which means it can be enabled as =y even
when its dependency is =m. This leads to a link failure:

drivers/media/usb/dvb-usb/cxusb-analog.o: In function `cxusb_medion_analog_init':
cxusb-analog.c:(.text+0x92): undefined reference to `v4l2_subdev_call_wrappers'
drivers/media/usb/dvb-usb/cxusb-analog.o: In function `cxusb_medion_register_analog':
cxusb-analog.c:(.text+0x466): undefined reference to `v4l2_device_register'
cxusb-analog.c:(.text+0x4c3): undefined reference to `v4l2_i2c_new_subdev'
cxusb-analog.c:(.text+0x4fb): undefined reference to `v4l2_subdev_call_wrappers'
...

Change the dependency only disallow the analog portion of the driver
in that configuration.

Fixes: e478d4054054 ("media: cxusb: add analog mode support for Medion MD95700")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/usb/dvb-usb/Kconfig

index 1a3e5f965ae4081db9fa20fd2cafb779b60cfa3f..2d7a5c1c84af6722dfdfc89547afa0aa7fea97fd 100644 (file)
@@ -150,6 +150,7 @@ config DVB_USB_CXUSB
 config DVB_USB_CXUSB_ANALOG
        bool "Analog support for the Conexant USB2.0 hybrid reference design"
        depends on DVB_USB_CXUSB && VIDEO_V4L2
+       depends on VIDEO_V4L2=y || VIDEO_V4L2=DVB_USB_CXUSB
        select VIDEO_CX25840
        select VIDEOBUF2_VMALLOC
        help