staging: rtl8188eu: Use eth_broadcast_addr() to assign broadcast address

Simplify the code by using eth_broadcast_addr() to assign broadcast
address and removing the unnecessary variable bc_addr.

Signed-off-by: Liu Shixin <liushixin2@huawei.com>
Link: https://lore.kernel.org/r/20210609085650.1269008-2-liushixin2@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
index 29b2d9f75fd5a46b10737fb0892a525e4809d0ec..9a883abc2cf8041f158bde4fb959fc0c950f7be3 100644 (file)
--- a/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
+++ b/drivers/staging/rtl8188eu/core/rtw_mlme_ext.c
@@ -315,7 +315,6 @@ static void issue_beacon(struct adapter *padapter, int timeout_ms)
        struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
        struct mlme_ext_info *pmlmeinfo = &pmlmeext->mlmext_info;
        struct wlan_bssid_ex *cur_network = &pmlmeinfo->network;
-       u8 bc_addr[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
 
        pmgntframe = alloc_mgtxmitframe(pxmitpriv);
        if (!pmgntframe) {
@@ -339,7 +338,7 @@ static void issue_beacon(struct adapter *padapter, int timeout_ms)
        fctrl = &pwlanhdr->frame_control;
        *(fctrl) = 0;
 
-       ether_addr_copy(pwlanhdr->addr1, bc_addr);
+       eth_broadcast_addr(pwlanhdr->addr1);
        ether_addr_copy(pwlanhdr->addr2, myid(&padapter->eeprompriv));
        ether_addr_copy(pwlanhdr->addr3, cur_network->MacAddress);
 
@@ -605,7 +604,6 @@ static int issue_probereq(struct adapter *padapter,
        struct mlme_priv *pmlmepriv = &padapter->mlmepriv;
        struct mlme_ext_priv *pmlmeext = &padapter->mlmeextpriv;
        int bssrate_len = 0;
-       u8 bc_addr[] = {0xff, 0xff, 0xff, 0xff, 0xff, 0xff};
 
        RT_TRACE(_module_rtl871x_mlme_c_, _drv_notice_, ("+%s\n", __func__));
 
@@ -633,8 +631,8 @@ static int issue_probereq(struct adapter *padapter,
                ether_addr_copy(pwlanhdr->addr3, da);
        } else {
                /*      broadcast probe request frame */
-               ether_addr_copy(pwlanhdr->addr1, bc_addr);
-               ether_addr_copy(pwlanhdr->addr3, bc_addr);
+               eth_broadcast_addr(pwlanhdr->addr1);
+               eth_broadcast_addr(pwlanhdr->addr3);
        }
 
        ether_addr_copy(pwlanhdr->addr2, mac);